classification
Title: Structural Pattern Matching (PEP 634)
Type: enhancement Stage: patch review
Components: Interpreter Core Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: brandtbucher Nosy List: BTaskaya, brandtbucher, gvanrossum, lys.nikolaou, pablogsal
Priority: normal Keywords: patch

Created on 2020-10-23 15:22 by brandtbucher, last changed 2020-10-28 16:07 by brandtbucher.

Pull Requests
URL Status Linked Edit
PR 22917 open brandtbucher, 2020-10-23 15:39
Messages (5)
msg379442 - (view) Author: Brandt Bucher (brandtbucher) * (Python committer) Date: 2020-10-23 15:22
PEP 634 has not yet been accepted, but we'd like to hit the ground running and get this into alphas as soon as it (hopefully) is.

Several people have volunteered to review the implementation, since it's so huge. Other reviews are very welcome, if anybody has a bit of time to pitch in. This touches tons of stuff: the parser, the compiler, the VM, the builtins, the stdlib, the tests... I'd like as many eyeballs as possible!

I'll have a draft PR up against master in a few minutes. Let's try to keep all of the review comments there.
msg379443 - (view) Author: Brandt Bucher (brandtbucher) * (Python committer) Date: 2020-10-23 15:27
Sorry, just resolving some changes with master. Are you parser people finished breaking my grammar yet? Sheesh. ;)
msg379831 - (view) Author: Brandt Bucher (brandtbucher) * (Python committer) Date: 2020-10-28 15:36
Thinking ahead...

A lot of work has gone into writing these PEPs...  we should see how much we can easily convert into actual docs. It seems to me:

- Parts of PEP 634 and PEP 635 can be worked into the language reference.

- Guido's overview (the appendix of PEP 636) can probably just be dropped verbatim into the What's New for 3.10.

- The rest of PEP 636 can just be lifted into the docs as a proper tutorial and linked to from the What's New.

Also, we need to document the stdlib changes (ast, collections, dataclasses, keyword, ...). The dis module docs are already part of the implementation.
msg379833 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2020-10-28 16:01
If you feel up to it, you might see if you could open a new, separate
(draft) PR that updates all those docs. (But you could also wait and see if
someone volunteers. There are some good doc writers active ATM.)
msg379834 - (view) Author: Brandt Bucher (brandtbucher) * (Python committer) Date: 2020-10-28 16:07
I'll wait till the SC makes a ruling, then send a message to our docs list (I think we have one)? I'm fine coordinating/reviewing that, or making PRs myself if nobody else steps up.
History
Date User Action Args
2020-10-28 16:07:22brandtbuchersetmessages: + msg379834
2020-10-28 16:01:41gvanrossumsetmessages: + msg379833
2020-10-28 15:36:44brandtbuchersetmessages: + msg379831
2020-10-23 15:39:38brandtbuchersetkeywords: + patch
pull_requests: + pull_request21846
2020-10-23 15:27:28brandtbuchersetmessages: + msg379443
2020-10-23 15:22:20brandtbuchercreate