classification
Title: Fix reference to ob_type in unionobject.c and ceval
Type: enhancement Stage: resolved
Components: Interpreter Core Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: vstinner Nosy List: Mark.Shannon, nascheme, vstinner
Priority: normal Keywords: patch

Created on 2020-10-20 19:18 by nascheme, last changed 2020-10-27 19:01 by Mark.Shannon. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 22829 merged nascheme, 2020-10-20 19:22
Messages (3)
msg379155 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2020-10-20 19:18
It is great that access to ob_type has been cleaned up to use an access macro.  There are two spots that still need fixing.

I think we should do something to help avoid this kind of thing slipping into the code in the future.  E.g. a special build flag that renames the ob_type member would work.  I'll make a separate bug for that.
msg379793 - (view) Author: Mark Shannon (Mark.Shannon) * (Python committer) Date: 2020-10-27 18:56
New changeset 0564aafb71a153dd0aca4b9266dfae9336a4f2cb by Neil Schemenauer in branch 'master':
bpo-42099: Fix reference to ob_type in unionobject.c and ceval (GH-22829)
https://github.com/python/cpython/commit/0564aafb71a153dd0aca4b9266dfae9336a4f2cb
msg379794 - (view) Author: Mark Shannon (Mark.Shannon) * (Python committer) Date: 2020-10-27 19:01
Thanks Neil
History
Date User Action Args
2020-10-27 19:01:50Mark.Shannonsetstatus: open -> closed
resolution: fixed
messages: + msg379794

stage: patch review -> resolved
2020-10-27 18:56:02Mark.Shannonsetnosy: + Mark.Shannon
messages: + msg379793
2020-10-20 19:22:34naschemesetkeywords: + patch
pull_requests: + pull_request21784
2020-10-20 19:18:59naschemecreate