classification
Title: Make filecmp more pythonic
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.9
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: alex.briskin, rhettinger
Priority: normal Keywords: patch

Created on 2020-10-18 16:54 by alex.briskin, last changed 2020-10-18 17:38 by rhettinger. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 22750 closed alex.briskin, 2020-10-18 16:56
Messages (2)
msg378877 - (view) Author: Alex (alex.briskin) * Date: 2020-10-18 16:54
Cleanup the filecmp file add typing and make it more pythonic
msg378879 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2020-10-18 17:38
In general, we don't accept patches like this:

* It risks breaks (in fact the tests are failing.
* We're not apply Black's quoting preferences to existing files.
* We're not yet adding type annotations through out.
* The PR introduces multiple new dependencies on other modules.
  This tends to slow down load time and complicate maintenance.
* There are subtle changes to the logic and API because
  of the dataclasses, cached_property, and lru_cache.
* We want to avoid code churn because it reduces stability
  and because it complicates maintenance (making it harder to
  apply fixes across versions).

Thank you for the suggestion, but we'll decline.
History
Date User Action Args
2020-10-18 17:38:23rhettingersetstatus: open -> closed

nosy: + rhettinger
messages: + msg378879

resolution: rejected
stage: patch review -> resolved
2020-10-18 16:56:50alex.briskinsetkeywords: + patch
stage: patch review
pull_requests: + pull_request21712
2020-10-18 16:54:54alex.briskincreate