➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-09-14 12:00 by pxeger, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 23957 | merged | trrhodes, 2020-12-26 20:19 | |
| Messages (5) | |||
|---|---|---|---|
| msg376877 - (view) | Author: Patrick Reader (pxeger) * | Date: 2020-09-14 12:00 | |
In typing.py, the `_allow_reckless_class_cheks` function is spelt wrong, and there is also a typo `instnance` in its docstring. I can do a PR but I thought I'd open an issue since it might be considered a breaking change (although it is `_private` so maybe not?) https://github.com/python/cpython/blob/1b4552c5e8e925f24c15f707050f22c977171125/Lib/typing.py#L1037 |
|||
| msg383826 - (view) | Author: Ross Rhodes (trrhodes) * | Date: 2020-12-26 20:21 | |
Hello Patrick, Thanks for opening this issue. I'm creating a PR to resolve the typo in "_allow_reckless_class_cheks", but I'm unable to find "instnance". Presumably the latter was resolved in an earlier PR. |
|||
| msg383827 - (view) | Author: Patrick Reader (pxeger) * | Date: 2020-12-26 20:24 | |
Maybe I added myself by accident while reading the code. Anyway, thanks and you're welcome |
|||
| msg383984 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2020-12-29 11:55 | |
New changeset c1af128f5a5893839536453dcc8b2ed7b95b3c3a by Ross in branch 'master': bpo-41781: Fix typo in internal function name in typing (GH-23957) https://github.com/python/cpython/commit/c1af128f5a5893839536453dcc8b2ed7b95b3c3a |
|||
| msg383985 - (view) | Author: Hai Shi (shihai1991) *  |
Date: 2020-12-29 12:07 | |
Thanks Patrick for your PR. Thanks Serhiy for your merge. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:35 | admin | set | github: 85947 |
| 2020-12-29 12:07:09 | shihai1991 | set | status: open -> closed nosy: + shihai1991 messages: + msg383985 resolution: fixed stage: patch review -> resolved |
| 2020-12-29 11:55:31 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg383984 |
| 2020-12-26 20:24:54 | pxeger | set | messages: + msg383827 |
| 2020-12-26 20:21:51 | trrhodes | set | messages: + msg383826 |
| 2020-12-26 20:19:51 | trrhodes | set | keywords:
+ patch nosy: + trrhodes pull_requests: + pull_request22804 stage: patch review |
| 2020-09-14 12:00:22 | pxeger | create | |