This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: PR proceeds to "awaiting core review" when changes are requested
Type: behavior Stage: resolved
Components: Versions:
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: Nosy List: FFY00, eric.smith, iritkatriel
Priority: normal Keywords:

Created on 2020-08-14 13:41 by iritkatriel, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Messages (3)
msg375404 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2020-08-14 13:41
When I click on "review" I get three options: comment, approve,
and request changes.  I assumed that "request changes"
would block the PR until the changes were made, but instead in the
case of PR 19046 it proceeded to "awaiting core review",
which seems to imply that it passed the first review.
msg375407 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2020-08-14 13:58
I think this belongs under
msg375417 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2020-08-14 16:47
It appears (as per core-mentoring list) that this is the intended behavior.
Date User Action Args
2022-04-11 14:59:34adminsetgithub: 85726
2020-08-14 16:47:33iritkatrielsetstatus: open -> closed
resolution: not a bug
messages: + msg375417

stage: resolved
2020-08-14 13:58:32eric.smithsetnosy: + eric.smith
messages: + msg375407
2020-08-14 13:47:45FFY00setnosy: + FFY00
2020-08-14 13:41:49iritkatrielcreate