This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Python 3.9.0rc1 "setup successful" dialog box overflow
Type: behavior Stage: resolved
Components: Installation, Windows Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: PeterL777, lukasz.langa, mhammond, miss-islington, paul.moore, steve.dower, tim.golden, wyz23x2, zach.ware
Priority: normal Keywords: patch

Created on 2020-08-12 01:04 by PeterL777, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
Python 3.9.0rc1 setup successful overflow dialog box.PNG PeterL777, 2020-08-12 01:04 Screen cap of dialog box
NewInstallSuccessPage.png steve.dower, 2020-08-13 20:52
Pull Requests
URL Status Linked Edit
PR 21871 merged steve.dower, 2020-08-13 21:42
PR 21872 merged miss-islington, 2020-08-13 23:36
Messages (10)
msg375206 - (view) Author: Peter Lovett (PeterL777) Date: 2020-08-12 01:04
"Setup was successful" dialog box text overflows the box, and last line can't be read.
msg375210 - (view) Author: wyz23x2 (wyz23x2) * Date: 2020-08-12 05:57
+1. I observe it too.
msg375345 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-08-13 20:52
So it'll take a bit more rearranging to get everything to fit - I've attached one proposal that shuffles the thanks to Mark Hammond down below the "enable long path names" button. (It's grey text in the screenshot, but I've switched it to black already.)

Alternatively, we could drop that note completely. It's entirely possible that Mark feels he's been thanked enough, and is now just embarrassed that we keep it around :) There are certainly enough other people with significant contributions on Windows who also deserve thanks.

One final option would be to move the "fix long paths" button to earlier in the install, though I'm not doing that during RC. The reason it's not part of the regular install is because it always requires Admin, and while it would be great to have it enabled by default, we already have enough people getting confused about whether admin is required to install or not (it's not, but you have to change the default launcher option on the front page).

Anyone have any thoughts?
msg375349 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2020-08-13 21:25
Yes, while I appreciate the gesture, I am somewhat embarrassed these days - as you say, many others deserve this more than me these days.

So please remove it.
msg375352 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-08-13 21:41
Thanks, Mark. We shall not hold you solely responsible for the port any longer ;)
msg375353 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-08-13 23:36
New changeset 6444ca946984c638c67a72aac22fd6d3cc650c16 by Steve Dower in branch 'master':
bpo-41526: Fixed layout of final page of the installer (GH-21871)
https://github.com/python/cpython/commit/6444ca946984c638c67a72aac22fd6d3cc650c16
msg375356 - (view) Author: miss-islington (miss-islington) Date: 2020-08-13 23:55
New changeset 75c2281762932c4e5f0bd7deae40ef014f704de2 by Miss Islington (bot) in branch '3.9':
bpo-41526: Fixed layout of final page of the installer (GH-21871)
https://github.com/python/cpython/commit/75c2281762932c4e5f0bd7deae40ef014f704de2
msg375359 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-08-14 00:36
Fixes merged, just need Łukasz to confirm it'll be in 3.9.0 and we can resolve this.
msg375555 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-08-17 15:55
Thanks for the report! This should be in the next 3.9 RC.
msg375562 - (view) Author: Peter Lovett (PeterL777) Date: 2020-08-17 18:06
:-)
History
Date User Action Args
2022-04-11 14:59:34adminsetgithub: 85698
2020-08-17 18:06:06PeterL777setmessages: + msg375562
2020-08-17 15:55:10steve.dowersetstatus: open -> closed
resolution: fixed
messages: + msg375555

stage: patch review -> resolved
2020-08-14 00:36:47steve.dowersetnosy: + lukasz.langa
messages: + msg375359
2020-08-13 23:55:44miss-islingtonsetmessages: + msg375356
2020-08-13 23:36:09miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request20997
2020-08-13 23:36:01steve.dowersetmessages: + msg375353
2020-08-13 21:42:49steve.dowersetkeywords: + patch
stage: patch review
pull_requests: + pull_request20996
2020-08-13 21:41:57steve.dowersetmessages: + msg375352
2020-08-13 21:25:54mhammondsetmessages: + msg375349
2020-08-13 20:52:09steve.dowersetfiles: + NewInstallSuccessPage.png
nosy: + mhammond
messages: + msg375345

2020-08-12 05:57:24wyz23x2setnosy: + wyz23x2
messages: + msg375210
2020-08-12 03:52:19zach.waresetassignee: steve.dower

components: + Windows
nosy: + paul.moore, tim.golden, zach.ware, steve.dower
2020-08-12 01:04:09PeterL777create