classification
Title: docstring errors in ipaddress.IPv4Network
Type: behavior Stage: patch review
Components: Documentation Versions: Python 3.10, Python 3.9, Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, eric.frederich, eric.smith, miss-islington, python-dev, terry.reedy
Priority: normal Keywords: patch

Created on 2020-08-04 19:54 by eric.frederich, last changed 2020-08-05 22:03 by eric.smith.

Pull Requests
URL Status Linked Edit
PR 21736 merged python-dev, 2020-08-04 19:58
PR 21746 merged miss-islington, 2020-08-05 18:45
PR 21747 merged miss-islington, 2020-08-05 21:35
Messages (8)
msg374841 - (view) Author: Eric Frederich (eric.frederich) * Date: 2020-08-04 19:54
The __init__ method for IPv4Network has a typo where it says all three of '192.0.2.0/24', '192.0.2.0/255.255.255.0' and '192.0.0.2/0.0.0.255' should be equal.
msg374894 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2020-08-05 18:45
New changeset 52f98424a55e14f05dfa7483cc0faf634a61c9ff by Eric L. Frederich in branch 'master':
bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
https://github.com/python/cpython/commit/52f98424a55e14f05dfa7483cc0faf634a61c9ff
msg374902 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2020-08-05 21:41
The issue resulting in the addition of a "backport-52f9842-3.9" branch to the main python/cpython repository.  I believe that this is a mistake and should be removed, but I don't know how.

When miss-islington fails to backport for reasons other than a merge conflict, the problem is likely transient  -- perhaps a timing issue or temporary resource unavailable issue that we have no control over.  The solution is to delete the backport label, close the label box, reopen the label box, add the label, and reclose.  I did this and the auto backport was generated.  (The 3.8 backport is ready to approve and merge.)
msg374903 - (view) Author: miss-islington (miss-islington) Date: 2020-08-05 21:43
New changeset b5789a7419655f66692fab463320048bd2290e81 by Miss Islington (bot) in branch '3.8':
bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
https://github.com/python/cpython/commit/b5789a7419655f66692fab463320048bd2290e81
msg374904 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2020-08-05 21:45
Since this is a trivial typo fix, I approved the backport for auto-merge.
msg374905 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2020-08-05 21:47
I was able to delete the spurious branch because it was not protected.
msg374906 - (view) Author: miss-islington (miss-islington) Date: 2020-08-05 21:53
New changeset b49b88a93a06b656d7f6a64d9d9e4828921d86eb by Miss Islington (bot) in branch '3.9':
bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
https://github.com/python/cpython/commit/b49b88a93a06b656d7f6a64d9d9e4828921d86eb
msg374907 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2020-08-05 22:03
Thanks, Terry. That was my fault, trying to cherry pick manually. I'm not sure why the original backport failed, and once I did the manual cherry pick as suggested I got called away for real work. As you say, I should have tried deleting the tag and re-adding it before I pulled out the cherry pick tool.

Thank you for cleaning up after me.
History
Date User Action Args
2020-08-05 22:03:53eric.smithsetmessages: + msg374907
2020-08-05 21:53:03miss-islingtonsetmessages: + msg374906
2020-08-05 21:47:21terry.reedysetmessages: + msg374905
2020-08-05 21:45:05terry.reedysetmessages: + msg374904
2020-08-05 21:43:20miss-islingtonsetmessages: + msg374903
2020-08-05 21:41:46terry.reedysettype: enhancement -> behavior
versions: - Python 3.5, Python 3.6, Python 3.7
2020-08-05 21:41:04terry.reedysetnosy: + terry.reedy
messages: + msg374902
2020-08-05 21:35:05miss-islingtonsetpull_requests: + pull_request20891
2020-08-05 18:45:13miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request20890
2020-08-05 18:45:00eric.smithsetnosy: + eric.smith
messages: + msg374894
2020-08-04 19:58:31python-devsetkeywords: + patch
nosy: + python-dev

pull_requests: + pull_request20880
stage: patch review
2020-08-04 19:54:05eric.frederichcreate