classification
Title: Make test_unicodedata pass when running without network
Type: behavior Stage: patch review
Components: Tests Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Jim.Jewett, yan12125
Priority: normal Keywords: patch

Created on 2020-07-25 10:26 by yan12125, last changed 2020-07-28 04:50 by Jim.Jewett.

Pull Requests
URL Status Linked Edit
PR 21615 open yan12125, 2020-07-25 10:38
Messages (2)
msg374249 - (view) Author: Chih-Hsuan Yen (yan12125) * Date: 2020-07-25 10:26
I setup a buildbot worker to test Python 3.x on Android monthly. This month network in the Android emulator is broken and I got an additional test failure:

0:05:28 load avg: 1.21 [376/423/11] test_unicodedata failed
test test_unicodedata failed -- Traceback (most recent call last):
  File "/data/local/tmp/lib/python3.10/urllib/request.py", line 1342, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
socket.gaierror: [Errno 7] No address associated with hostname

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/local/tmp/lib/python3.10/test/test_unicodedata.py", line 329, in test_normalization
    testdata = open_urlresource(TESTDATAURL, encoding="utf-8",
urllib.error.URLError: <urlopen error [Errno 7] No address associated with hostname>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/local/tmp/lib/python3.10/test/test_unicodedata.py", line 335, in test_normalization
    self.fail(f"Could not retrieve {TESTDATAURL}")
AssertionError: Could not retrieve http://www.pythontest.net/unicode/13.0.0/NormalizationTest.txt

I propose wrapping the test in socket_helper.transient_internet() so that this test is skipped if the Internet is not available.
msg374462 - (view) Author: Jim Jewett (Jim.Jewett) (Python triager) Date: 2020-07-28 04:50
Looks Good To Me
History
Date User Action Args
2020-07-28 04:50:38Jim.Jewettsetnosy: + Jim.Jewett
messages: + msg374462
2020-07-25 10:38:12yan12125setkeywords: + patch
stage: patch review
pull_requests: + pull_request20757
2020-07-25 10:26:54yan12125create