Title: socket.TCP_* no longer available with cygwin 3.1.6+
Type: compile error Stage: patch review
Components: Build Versions: Python 3.8, Python 3.7, Python 3.6
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: ZackerySpytz, erik.bray, lazka, matzeri
Priority: normal Keywords: patch

Created on 2020-07-23 07:51 by lazka, last changed 2021-02-13 09:12 by lazka.

File name Uploaded Description Edit
3.6.12-socketmodule.patch matzeri, 2021-01-02 23:24 Patch used on Cygwin packages
Pull Requests
URL Status Linked Edit
PR 21649 open ZackerySpytz, 2020-07-28 01:23
Messages (3)
msg374126 - (view) Author: Christoph Reiter (lazka) * Date: 2020-07-23 07:51
The TCP macros are provided by netinet/tcp.h, which for some reason is skipped here:

Until cygwin 3.1.6 these macros were also provided by sys/socket.h, but this got removed in;a=commit;h=e037192b505b4f233fca9a6deafc9797210f6693

This leads to socket.TCP_NODELAY for example not being available anymore.

git blame leads me to introducing this special case, which isn't very helpful. I'd suggest to just remove the cygwin check and always include it (which works fine on my machine)

Downstream bug report for extra context:
msg384245 - (view) Author: Marco Atzeri (matzeri) Date: 2021-01-02 23:24
The Analysis is correct. 
Removing the test for CYGWIN and always include the 

solved the problem building all python (3.6,3.7,3.8) packages

attached patch used on the build.
Similar one was applied to the rebuild of 2.7.18
msg386918 - (view) Author: Christoph Reiter (lazka) * Date: 2021-02-13 09:12
ping. The PR looks good to me.
Date User Action Args
2021-02-13 09:12:29lazkasetmessages: + msg386918
2021-01-02 23:24:50matzerisetfiles: + 3.6.12-socketmodule.patch
versions: + Python 3.6, Python 3.7
nosy: + matzeri

messages: + msg384245
2020-07-28 01:23:43ZackerySpytzsetkeywords: + patch
nosy: + ZackerySpytz

pull_requests: + pull_request20789
stage: patch review
2020-07-23 18:21:25lazkasetnosy: + erik.bray
2020-07-23 07:51:44lazkacreate