➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-07-08 17:20 by tontinton, last changed 2022-04-11 14:59 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 21399 | open | tontinton, 2020-07-08 17:37 | |
| Messages (4) | |||
|---|---|---|---|
| msg373324 - (view) | Author: Tony (tontinton) * | Date: 2020-07-08 17:20 | |
In IocpProactor I saw that the callbacks to the functions recv, recv_into, recvfrom, sendto, send and sendfile all give the same callback function for when the overlapped operation is done. I just wanted cleaner code so I made a static function inside the class that I give to each of these functions as the overlapped callbacks. |
|||
| msg373533 - (view) | Author: Jim Jewett (Jim.Jewett) *  |
Date: 2020-07-11 18:41 | |
Looks good to me. I at first worried that the different function names were useful metadata that was getting lost -- but the names were already duplicated in several cases. *If* that is still a concern for the committer, then instead of repeating the code (as current production does), each section should just say newname=origname before registering the static method (as the patch does), and should bind a distinct name for each usage. |
|||
| msg373534 - (view) | Author: Tony (tontinton) * | Date: 2020-07-11 18:47 | |
I feel like the metadata is not really a concern here. I like when there is no code duplication :) |
|||
| msg376081 - (view) | Author: Tony (tontinton) * | Date: 2020-08-29 21:21 | |
bump |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:33 | admin | set | github: 85418 |
| 2020-08-30 05:01:41 | Jim.Jewett | set | stage: patch review -> commit review |
| 2020-08-29 21:21:02 | tontinton | set | messages: + msg376081 |
| 2020-07-11 18:47:15 | tontinton | set | messages: + msg373534 |
| 2020-07-11 18:41:55 | Jim.Jewett | set | nosy:
+ Jim.Jewett messages: + msg373533 versions: + Python 3.10 |
| 2020-07-08 17:37:58 | tontinton | set | keywords:
+ patch stage: patch review pull_requests: + pull_request20547 |
| 2020-07-08 17:20:08 | tontinton | create | |