During the construction of a ZipFile object, a 
file is opened and assigned to self.fp.

If anything goes wrong, i.e. the file is not a zipfile,
it is not closed explicitly.  

On Windows, this does not work:

import zipfile, os

filename="test.zip" # it's a broken one
try:
  zf=zipfile.ZipFile(filename)
  zf.close()
finally:
  os.unlink(zipfile)

=> OSError: [errno 13] Permission denied "test.zip"

(on Unix, the file stays open too, but unlink doesn't
fail)

Logged In: YES 
user_id=137089

os.unlink(zipfile) should read os.unlink(filename). 

Logged In: YES 
user_id=21627

Normally, the file should be closed when the last reference
to the zipfile is dropped. In this case, the traceback holds
onto the innermost frame (i.e. the one of __init__), which
holds onto self, which is the ZipFile. I agree this should
be fixed in __init__.

Logged In: YES 
user_id=3066

I've attached a patch and a test case, but I'm not running Windows.

Tim, can you test the patch and assign it back to me with your comments?

Logged In: YES 
user_id=31435

Since I had to apply the patch to test it, and it worked 
fine, I checked it in too:

Lib/zipfile.py rev 1.11
Lib/test/test_zipfile.py rev 1.6