Issue 41190: msilib: SetProperty() accepts str, but GetProperty() returns bytes

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/85362

classification

Title:	msilib: SetProperty() accepts str, but GetProperty() returns bytes
Type:	behavior	Stage:
Components:	Windows	Versions:

process

Status:	open	Resolution:
Dependencies:		Superseder:
Assigned To:		Nosy List:	paul.moore, serhiy.storchaka, steve.dower, tim.golden, zach.ware
Priority:	normal	Keywords:

Created on 2020-07-01 18:15 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin.

Messages (1)
msg372777 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2020-07-01 18:15
There is an inconsistency in the _msi.SummaryInformation class. Its method SetProperty() accepts str, but GetProperty() returns bytes (encoded with the Windows ANSI encoding). Since os.fsencode()/os.fsdecode() now use UTF-8 encoding, it is not so easy to convert between bytes and str. Also, the encoding with the Windows ANSI encoding is lossy, so it may be that there is a loss in GetProperty().

msg372777 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2020-07-01 18:15

There is an inconsistency in the _msi.SummaryInformation class. Its method SetProperty() accepts str, but GetProperty() returns bytes (encoded with the Windows ANSI encoding).

Since os.fsencode()/os.fsdecode() now use UTF-8 encoding, it is not so easy to convert between bytes and str. Also, the encoding with the Windows ANSI encoding is lossy, so it may be that there is a loss in GetProperty().

History
Date	User	Action	Args
2022-04-11 14:59:33	admin	set	github: 85362
2020-07-01 18:15:29	serhiy.storchaka	create