classification
Title: Threads can fail to start
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Barney Stratford, pablogsal, python-dev
Priority: normal Keywords: patch

Created on 2020-06-28 16:01 by Barney Stratford, last changed 2021-02-02 20:24 by pablogsal. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 21201 merged python-dev, 2020-06-28 19:59
Messages (2)
msg372521 - (view) Author: Barney Stratford (Barney Stratford) * Date: 2020-06-28 16:01
>>> import threading
>>> class foo (object):
...     def __bool__ (self):
...         return False
...     def __call__ (self):
...         print ("Running")
...
>>> threading.Thread (target = foo ()).start ()

The expected result of these commands would be for the thread to print
"Running". However, in actual fact it prints nothing at all. This is
because threading.Thread.run only runs the target if it is True as a
boolean. This is presumably to make the thread do nothing at all if
the target is None. In this case, I have a legitimate target that is
False as a boolean.

I propose to remove the test altogether. The effect of this is that
failure to set the target of the thread, or setting a non-callable
target, will cause the thread to raise a TypeError as soon as it is
started. Forgetting to set the target is in almost every case a bug,
and bugs should never be silent.

PR to follow.
msg386169 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2021-02-02 20:24
New changeset 01c4fddc4b2ac707f226e0bd92679588d2252cc4 by BarneyStratford in branch 'master':
bpo-41149: Fix a bug in threading that causes fals-y threads callables to fail to start. (GH-21201)
https://github.com/python/cpython/commit/01c4fddc4b2ac707f226e0bd92679588d2252cc4
History
Date User Action Args
2021-02-02 20:24:38pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-02-02 20:24:31pablogsalsetnosy: + pablogsal
messages: + msg386169
2020-06-28 19:59:39python-devsetkeywords: + patch
nosy: + python-dev

pull_requests: + pull_request20356
stage: patch review
2020-06-28 16:01:04Barney Stratfordcreate