classification
Title: Build failure on macOS 11 (beta)
Type: Stage: patch review
Components: Build, macOS Versions: Python 3.10, Python 3.9, Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: ronaldoussoren Nosy List: Maxime Belanger, Mika_Hawkins, corona10, eamanu, erlendaasland, lawrence-danna-apple, mark.dickinson, miss-islington, ned.deily, ronaldoussoren, skrah
Priority: normal Keywords: patch

Created on 2020-06-24 11:51 by ronaldoussoren, last changed 2020-08-17 22:25 by ned.deily.

Pull Requests
URL Status Linked Edit
PR 21113 merged ronaldoussoren, 2020-06-24 12:10
PR 21153 merged miss-islington, 2020-06-25 14:56
PR 21154 merged miss-islington, 2020-06-25 14:56
PR 21155 merged miss-islington, 2020-06-25 14:56
PR 21174 merged ned.deily, 2020-06-27 08:20
PR 21175 merged miss-islington, 2020-06-27 08:45
PR 21176 merged miss-islington, 2020-06-27 08:45
PR 21224 open lawrence-danna-apple, 2020-06-30 04:22
PR 21228 merged lawrence-danna-apple, 2020-06-30 04:43
PR 21239 closed lawrence-danna-apple, 2020-06-30 17:23
PR 21241 open lawrence-danna-apple, 2020-06-30 18:23
PR 21242 closed lawrence-danna-apple, 2020-06-30 18:25
PR 21249 open lawrence-danna-apple, 2020-07-01 01:09
PR 21266 open lawrence-danna-apple, 2020-07-01 17:40
PR 21268 open lawrence-danna-apple, 2020-07-01 19:02
PR 21564 open ronaldoussoren, 2020-07-20 13:55
PR 21576 closed lawrence-danna-apple, 2020-07-21 02:28
PR 21577 open lawrence-danna-apple, 2020-07-21 06:01
PR 21583 open ronaldoussoren, 2020-07-21 11:27
PR 21588 open lawrence-danna-apple, 2020-07-21 22:30
Messages (15)
msg372245 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2020-06-24 11:51 
macOS 11 is darwin 20.0.0. This confuses the configure script, resulting in defining _POSIX_C_SOURCE and friends.
msg372371 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-06-25 14:55 
New changeset 8ea6353f60625c96ce96588c70ff24a77f8c71f9 by Ronald Oussoren in branch 'master':
BPO-41100: Support macOS 11 when building (GH-21113)
https://github.com/python/cpython/commit/8ea6353f60625c96ce96588c70ff24a77f8c71f9
msg372374 - (view) Author: miss-islington (miss-islington) Date: 2020-06-25 15:13 
New changeset ad7a66731f2681c626f32f097e1e91cdc02330ab by Miss Islington (bot) in branch '3.9':
BPO-41100: Support macOS 11 when building (GH-21113)
https://github.com/python/cpython/commit/ad7a66731f2681c626f32f097e1e91cdc02330ab
msg372375 - (view) Author: miss-islington (miss-islington) Date: 2020-06-25 15:15 
New changeset c4a53e48a98b3d8fdcfc11d1b5af3ea0dd987a88 by Miss Islington (bot) in branch '3.8':
BPO-41100: Support macOS 11 when building (GH-21113)
https://github.com/python/cpython/commit/c4a53e48a98b3d8fdcfc11d1b5af3ea0dd987a88
msg372376 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-06-25 15:15 
New changeset cfbc759f918d646a59acb99251fc10b3900248a6 by Miss Islington (bot) in branch '3.7':
BPO-41100: Support macOS 11 when building (GH-21113) (GH-21155)
https://github.com/python/cpython/commit/cfbc759f918d646a59acb99251fc10b3900248a6
msg372456 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-06-27 08:44 
New changeset 2f168c6356f92c38ae7751d2faf2b266a9356229 by Ned Deily in branch 'master':
bpo-41100: clarify NEWS item about macOS 11 support (GH-21174)
https://github.com/python/cpython/commit/2f168c6356f92c38ae7751d2faf2b266a9356229
msg372457 - (view) Author: miss-islington (miss-islington) Date: 2020-06-27 08:51 
New changeset 1a0c581a94892fbd8fa70905130776ef7a059d97 by Miss Islington (bot) in branch '3.9':
bpo-41100: clarify NEWS item about macOS 11 support (GH-21174)
https://github.com/python/cpython/commit/1a0c581a94892fbd8fa70905130776ef7a059d97
msg372458 - (view) Author: miss-islington (miss-islington) Date: 2020-06-27 08:52 
New changeset 027bba2eada175358a7f34cad155b25e1b805082 by Miss Islington (bot) in branch '3.8':
bpo-41100: clarify NEWS item about macOS 11 support (GH-21174)
https://github.com/python/cpython/commit/027bba2eada175358a7f34cad155b25e1b805082
msg372652 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-06-30 04:30 
[Moving the discussion from Issue41164 to here.]

The change in PR 21224 may be needed to successfully build but I'm not sure whether that LIBTOOL_CRUFT stuff is still needed. With a squick search, I don't see any references to it anymore. But it won't hurt to add it.
msg372672 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2020-06-30 09:15 
New changeset 604d95e235d86465b8c17f02095edcaf18464d4c by Lawrence D'Anna in branch 'master':
bpo-41100: fix _decimal for arm64 Mac OS (GH-21228)
https://github.com/python/cpython/commit/604d95e235d86465b8c17f02095edcaf18464d4c
msg372680 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2020-06-30 11:12 
A first testrun on the arm-mac resulted in test failures in test_distutils (in particular test_deployment_target_default in the distutils test).  That's something I have to investigate further.
msg372716 - (view) Author: Lawrence D'Anna (lawrence-danna-apple) * Date: 2020-06-30 18:29 
I've created 3 patches for ctypes

* use system libffi instead of vendored one on Mac OS 10.15 and up
* use correct ABI for variadic functions on arm64
* check for libs in the dyld shared cache

With those, test_ctypes should all pass on arm64
msg374315 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2020-07-26 14:31 
PR21564 is my attempt to merge all changes needed to support macOS 11 and arm64.  To be honest I had lost track of what's needed.

With this the patch the tests pass on my DTK system. 

TODO:
- Verify builds on older macOS versions
- Maybe: support building using non-system libffi on macOS


PR 21583 is a separate attempt at doing the code changes that are needed to build with the latest SDK and deploy on macOS 10.9.  This patch is still in a fairly rough state, and needs more testing (I haven't done any testing on older platforms yet)

TODO:
- Test on macOS 10.9
- Tweak the build-installer script and possibly _osx_support.py: the minimal deployment target for arm64 should be macOS 11.0.
- Tweak the build-installer script to build an optimised version

TDB:
- Keep this as two separate PRs or merge them? 
  The latter makes testing easier, but review harder
msg375532 - (view) Author: Mika Hawkins (Mika_Hawkins) Date: 2020-08-17 08:17 
Hi,
What you can do is to verify builds on older macOS versions and you can also support building using non-system libffi on macOS.

Hope this hhelps...

Regards,
Mika Hawkins
msg375572 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-08-17 22:25 
New changeset a0ad82959652ff64c99231f457fd740b17330514 by Ned Deily in branch '3.7':
bpo-41100: additional fixes for testing on macOS 11 Big Sur Intel
https://github.com/python/cpython/commit/a0ad82959652ff64c99231f457fd740b17330514
History
Date User Action Args
2020-08-17 22:25:43ned.deilysetmessages: + msg375572
2020-08-17 08:17:38Mika_Hawkinssetnosy: + Mika_Hawkins
messages: + msg375532
2020-08-12 22:48:20Maxime Belangersetnosy: + Maxime Belanger
2020-07-26 14:31:40ronaldoussorensetmessages: + msg374315
2020-07-26 14:14:50ronaldoussorenlinkissue41090 superseder
2020-07-22 17:10:15erlendaaslandsetnosy: + erlendaasland
2020-07-21 22:30:24lawrence-danna-applesetpull_requests: + pull_request20728
2020-07-21 11:27:32ronaldoussorensetpull_requests: + pull_request20724
2020-07-21 06:01:51lawrence-danna-applesetpull_requests: + pull_request20721
2020-07-21 02:28:12lawrence-danna-applesetpull_requests: + pull_request20720
2020-07-20 13:55:23ronaldoussorensetpull_requests: + pull_request20709
2020-07-02 02:22:48eamanusetnosy: + eamanu
2020-07-01 19:14:49mark.dickinsonsetnosy: + mark.dickinson
2020-07-01 19:02:47lawrence-danna-applesetpull_requests: + pull_request20418
2020-07-01 17:40:01lawrence-danna-applesetpull_requests: + pull_request20414
2020-07-01 07:38:29ronaldoussorenlinkissue41179 superseder
2020-07-01 01:09:06lawrence-danna-applesetpull_requests: + pull_request20399
2020-06-30 18:29:07lawrence-danna-applesetmessages: + msg372716
2020-06-30 18:25:26lawrence-danna-applesetpull_requests: + pull_request20394
2020-06-30 18:23:27lawrence-danna-applesetpull_requests: + pull_request20393
2020-06-30 17:23:35lawrence-danna-applesetpull_requests: + pull_request20391
2020-06-30 11:12:47ronaldoussorensetmessages: + msg372680
2020-06-30 09:15:56skrahsetnosy: + skrah
messages: + msg372672
2020-06-30 04:43:07lawrence-danna-applesetpull_requests: + pull_request20382
2020-06-30 04:33:11corona10setnosy: + corona10
2020-06-30 04:30:15ned.deilysetmessages: + msg372652
2020-06-30 04:25:34ned.deilylinkissue41164 superseder
2020-06-30 04:22:25lawrence-danna-applesetnosy: + lawrence-danna-apple
pull_requests: + pull_request20381
2020-06-27 08:52:53miss-islingtonsetmessages: + msg372458
2020-06-27 08:51:59miss-islingtonsetmessages: + msg372457
2020-06-27 08:45:38miss-islingtonsetpull_requests: + pull_request20334
2020-06-27 08:45:28miss-islingtonsetpull_requests: + pull_request20333
2020-06-27 08:44:59ned.deilysetmessages: + msg372456
2020-06-27 08:20:36ned.deilysetpull_requests: + pull_request20332
2020-06-25 15:15:55ned.deilysetmessages: + msg372376
2020-06-25 15:15:10miss-islingtonsetmessages: + msg372375
2020-06-25 15:13:43miss-islingtonsetmessages: + msg372374
2020-06-25 14:56:22miss-islingtonsetpull_requests: + pull_request20314
2020-06-25 14:56:15miss-islingtonsetpull_requests: + pull_request20313
2020-06-25 14:56:07miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request20312
2020-06-25 14:55:57ned.deilysetmessages: + msg372371
2020-06-24 12:10:37ronaldoussorensetkeywords: + patch
stage: patch review
pull_requests: + pull_request20276
2020-06-24 11:51:07ronaldoussorencreate