➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-06-20 17:26 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 21006 | merged | serhiy.storchaka, 2020-06-20 17:30 | |
| Messages (3) | |||
|---|---|---|---|
| msg371944 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2020-06-20 17:26 | |
There are ancient tests for printing some basic types: str (actually a mix of Python 2 str and unicode), list, tuple, bool, set, deque, defaultdict. They are essentially tests for the tp_print slot. But since the tp_print slot is no longer used, they are virtually repeat tests for str or repr. These tests are outdated and no longer serve the initial purpose. To avoid confusion it is worth to remove them. |
|||
| msg371985 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2020-06-21 08:11 | |
New changeset f9bab74d5b34c64cf061e1629ff5f3092a4ca9b3 by Serhiy Storchaka in branch 'master': bpo-41055: Remove outdated tests for the tp_print slot. (GH-21006) https://github.com/python/cpython/commit/f9bab74d5b34c64cf061e1629ff5f3092a4ca9b3 |
|||
| msg371996 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2020-06-21 13:59 | |
Nice. I would have found the removed tests confusing. I presume tp_print had something to do with print as a statement. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:32 | admin | set | github: 85227 |
| 2020-06-21 13:59:12 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg371996 |
| 2020-06-21 11:07:17 | serhiy.storchaka | link | issue41063 dependencies |
| 2020-06-21 09:32:55 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-06-21 08:11:21 | serhiy.storchaka | set | messages: + msg371985 |
| 2020-06-20 17:30:07 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request20180 |
| 2020-06-20 17:26:58 | serhiy.storchaka | create | |