➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-06-20 16:25 by nnemkin, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 21004 | merged | nnemkin, 2020-06-20 16:32 | |
| PR 21091 | merged | miss-islington, 2020-06-23 19:06 | |
| Messages (5) | |||
|---|---|---|---|
| msg371941 - (view) | Author: Nikita Nemkin (nnemkin) * | Date: 2020-06-20 16:25 | |
Every Windows project has a custom target (included from pyproject.props) that generates a header with definitions for resource files. Those definitions (PYTHON_DLL_NAME and FIELD3) can be passed directly to resource compiler. Another definition (MS_DLL_ID) doesn't need to be a resource at all. It was used in the past to initialize PyWin_DLLVersionString in dl_nt.c, but that code is now dead. |
|||
| msg372120 - (view) | Author: Steve Dower (steve.dower) *  |
Date: 2020-06-22 21:28 | |
Looks good. Let's rename PYTHON_DLL_NAME to ORIGINAL_FILENAME, since it took me 10 minutes to figure out that that's how it's used... We'll backport this one to 3.9 before RC. No NEWS file required. |
|||
| msg372196 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2020-06-23 19:06 | |
New changeset 4efc3360c9a83d5891f27ed67b4f0ab7275d2ab4 by Nikita Nemkin in branch 'master': bpo-41054: Simplify resource compilation on Windows (GH-21004) https://github.com/python/cpython/commit/4efc3360c9a83d5891f27ed67b4f0ab7275d2ab4 |
|||
| msg372197 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-23 19:27 | |
New changeset cebd43fbfd25a80404728f73edc301f9558d9410 by Miss Islington (bot) in branch '3.9': bpo-41054: Simplify resource compilation on Windows (GH-21004) https://github.com/python/cpython/commit/cebd43fbfd25a80404728f73edc301f9558d9410 |
|||
| msg372201 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2020-06-23 19:34 | |
Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:32 | admin | set | github: 85226 |
| 2020-06-23 19:34:43 | steve.dower | set | status: open -> closed resolution: fixed messages: + msg372201 stage: patch review -> resolved |
| 2020-06-23 19:27:38 | miss-islington | set | messages: + msg372197 |
| 2020-06-23 19:06:10 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request20257 |
| 2020-06-23 19:06:04 | steve.dower | set | messages: + msg372196 |
| 2020-06-22 21:28:11 | steve.dower | set | messages:
+ msg372120 versions: + Python 3.9 |
| 2020-06-20 16:32:55 | nnemkin | set | keywords:
+ patch stage: patch review pull_requests: + pull_request20178 |
| 2020-06-20 16:25:11 | nnemkin | create | |