This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix test_modulefinder
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.10, Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2020-06-19 20:06 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 20991 merged serhiy.storchaka, 2020-06-19 20:08
PR 20992 merged miss-islington, 2020-06-19 21:06
PR 20993 merged miss-islington, 2020-06-19 21:06
Messages (4)
msg371897 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-06-19 20:06
There is a bug in test_modulefinder. The bytes string literal contains \u2090.

1. Since \u is not recognized escape sequence in bytes literals, compiling the file emits a deprecation warning:

/home/serhiy/py/cpython/Lib/test/test_modulefinder.py:281: DeprecationWarning: invalid escape sequence \u
  b"""\

2. b"\u2090" is interpreted as b"\\u2090", but actually the test implies that it should be a bytes sequence b'\xe2\x82\x90' which is valid in UTF-8 but is not a valid in CP1252.
msg371901 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-06-19 21:06
New changeset a041e116db5f1e78222cbf2c22aae96457372680 by Serhiy Storchaka in branch 'master':
bpo-41040: Fix test_modulefinder. (GH-20991)
https://github.com/python/cpython/commit/a041e116db5f1e78222cbf2c22aae96457372680
msg371904 - (view) Author: miss-islington (miss-islington) Date: 2020-06-19 21:25
New changeset 80651ab9e3f9d9a89e566a0b87a51b28720094f0 by Miss Islington (bot) in branch '3.8':
bpo-41040: Fix test_modulefinder. (GH-20991)
https://github.com/python/cpython/commit/80651ab9e3f9d9a89e566a0b87a51b28720094f0
msg371905 - (view) Author: miss-islington (miss-islington) Date: 2020-06-19 21:26
New changeset 75238869b546526ac9e18d6169f3dc87c7f94eef by Miss Islington (bot) in branch '3.9':
bpo-41040: Fix test_modulefinder. (GH-20991)
https://github.com/python/cpython/commit/75238869b546526ac9e18d6169f3dc87c7f94eef
History
Date User Action Args
2022-04-11 14:59:32adminsetgithub: 85212
2020-06-22 07:42:11serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-06-19 21:26:07miss-islingtonsetmessages: + msg371905
2020-06-19 21:25:32miss-islingtonsetmessages: + msg371904
2020-06-19 21:06:44miss-islingtonsetpull_requests: + pull_request20168
2020-06-19 21:06:37miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request20167
2020-06-19 21:06:13serhiy.storchakasetmessages: + msg371901
2020-06-19 20:08:28serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request20166
2020-06-19 20:06:42serhiy.storchakacreate