This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Remove unused and unneeded function declaration from sqlite3 header files
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, erlendaasland
Priority: normal Keywords: patch

Created on 2020-06-12 11:21 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 20828 merged erlendaasland, 2020-06-12 11:24
Messages (3)
msg371353 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2020-06-12 11:21
The following function declarations can safely be removed because they're either unused or unneeded.

In Modules/_sqlite/cache.h:
pysqlite_node_init()     // unused; no function definition
pysqlite_node_dealloc()  // unneeded; file scope
pysqlite_cache_init()    // unneeded; file scope
pysqlite_cache_dealloc() // unneeded; file scope

In Modules/_sqlite/connection.h:
pysqlite_connection_alloc()    // unused; no function definition
pysqlite_connection_dealloc()  // unneeded; file scope
pysqlite_connection_cursor()   // unneeded; file scope
pysqlite_connection_close()    // unneeded; file scope
pysqlite_connection_rollback() // unneeded; file scope
pysqlite_connection_new()      // unused; no function definition
pysqlite_connection_init()     // unneeded; file scope

In Modules/_sqlite/cursor.h:
pysqlite_cursor_execute()     // unneeded; file scope
pysqlite_cursor_executemany() // unneeded; file scope
pysqlite_cursor_getiter()     // unused; no function definition
pysqlite_cursor_iternext()    // unneeded; file scope
pysqlite_cursor_fetchone()    // unneeded; file scope
pysqlite_cursor_fetchmany()   // unneeded; file scope
pysqlite_cursor_fetchall()    // unneeded; file scope
pysqlite_noop()               // unneeded; file scope
pysqlite_cursor_close()       // unneeded; file scope

In Modules/_sqlite/prepare_protocol.h:
pysqlite_prepare_protocol_init()    // unneeded; file scope
pysqlite_prepare_protocol_dealloc() // unneeded; file scope

In Modules/_sqlite/statement.h:
pysqlite_statement_dealloc() // unneeded; file scope
msg384461 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-01-06 00:56
New changeset 203b2493ae6fd7c1f039f3f906f087d67d9100d5 by Erlend Egeberg Aasland in branch 'master':
bpo-40959: Remove unused declarations from sqlite3 headers (GH-20828)
https://github.com/python/cpython/commit/203b2493ae6fd7c1f039f3f906f087d67d9100d5
msg384462 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-01-06 00:56
Thank you!
History
Date User Action Args
2022-04-11 14:59:32adminsetgithub: 85131
2021-01-06 00:56:35berker.peksagsetstatus: open -> closed
resolution: fixed
messages: + msg384462

stage: patch review -> resolved
2021-01-06 00:56:08berker.peksagsetnosy: + berker.peksag
messages: + msg384461
2020-06-12 11:24:44erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request20023
2020-06-12 11:21:57erlendaaslandcreate