classification
Title: Patch to implement a real poplib test suite
Type: Stage:
Components: Tests Versions: Python 3.0, Python 3.1, Python 2.7
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, facundobatista, giampaolo.rodola, gvanrossum
Priority: normal Keywords: patch

Created on 2008-10-09 15:23 by giampaolo.rodola, last changed 2008-10-11 17:26 by benjamin.peterson. This issue is now closed.

Files
File name Uploaded Description Edit
test_poplib.patch giampaolo.rodola, 2008-10-09 15:23 gives poplib a real test suite
Messages (2)
msg74581 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2008-10-09 15:23
poplib module is currently lacking a test suite which actually connects
to a server and uses the POP3 class methods and facilities.
Bug #3727, discovered just a bunch of days before the stable release of
Python 3.0 is an example of how much a test suite is necessary.

As done in #3939 for the ftplib module, in attachment I provide a test
suite which implements an asyncore-based dummy POP3 server which sends
fixed response codes that I used to test all the relevant POP3 class
methods.
Tests for the POP3_SSL class are also included.
Although not that useful (IMHO) I didn't remove the old tests about
timeouts.

Tested successfully against Python 2.6 on Windows XP SP3, Debian Etch
and FreeBSD 7.0.
msg74661 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-10-11 17:26
Thanks for the patch; it's look good. Applied in r66878.
History
Date User Action Args
2008-10-11 17:26:02benjamin.petersonsetstatus: open -> closed
resolution: accepted
messages: + msg74661
2008-10-09 15:23:57giampaolo.rodolacreate