This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.10, Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, remi.lapeyre, vinay.sajip
Priority: normal Keywords: patch

Created on 2020-06-01 00:39 by remi.lapeyre, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 20563 merged remi.lapeyre, 2020-06-01 00:46
Messages (6)
msg370522 - (view) Author: Rémi Lapeyre (remi.lapeyre) * Date: 2020-06-01 00:39
Both are not documented and synonymous for critical() but don't raise a DeprecationWarning.
msg370528 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2020-06-01 03:58
Well, I'm not planning to actually deprecate and then remove them - as they're not documented, it's unlikely that new code will use them, and there's no particular reason to break old code that happens to use them.
msg370540 - (view) Author: Rémi Lapeyre (remi.lapeyre) * Date: 2020-06-01 07:43
Thanks, I was wondering about that. I didn't know what is the status of the function exactly and found https://bugs.python.org/msg344080.

While they are not documented, you can find them in dir() and in the help, maybe they should have a docstring?
msg370648 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2020-06-03 08:48
Yes, they could have a docstring indicating that it is better to use critical(). Feel free to update the PR along that line.
msg370710 - (view) Author: Rémi Lapeyre (remi.lapeyre) * Date: 2020-06-04 13:48
Thanks for the feedback, I updated the PR accordingly.
msg371534 - (view) Author: miss-islington (miss-islington) Date: 2020-06-15 08:03
New changeset 25f38d7044a3a47465edd851c4e04f337b2c4b9b by Rémi Lapeyre in branch 'master':
bpo-40836: Add docstring to logging.fatal() and logging.Logger.fatal() (GH-20563)
https://github.com/python/cpython/commit/25f38d7044a3a47465edd851c4e04f337b2c4b9b
History
Date User Action Args
2022-04-11 14:59:31adminsetgithub: 85013
2020-06-15 12:18:37remi.lapeyresetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-06-15 08:03:24miss-islingtonsetnosy: + miss-islington
messages: + msg371534
2020-06-04 13:48:57remi.lapeyresetmessages: + msg370710
2020-06-03 08:48:28vinay.sajipsetmessages: + msg370648
2020-06-01 07:43:52remi.lapeyresetmessages: + msg370540
2020-06-01 03:58:09vinay.sajipsetnosy: + vinay.sajip
messages: + msg370528
2020-06-01 00:46:12remi.lapeyresetkeywords: + patch
stage: patch review
pull_requests: + pull_request19804
2020-06-01 00:39:39remi.lapeyrecreate