➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-05-22 22:16 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 0001-Use-PyModule_AddObject-correctly-in-sqlite3.patch | erlendaasland, 2020-05-22 22:15 | |||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 20323 | merged | erlendaasland, 2020-05-22 22:18 | |
| PR 20425 | merged | miss-islington, 2020-05-26 12:18 | |
| Messages (4) | |||
|---|---|---|---|
| msg369658 - (view) | Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2020-05-22 22:15 | |
According to the documentation, PyModule_AddObject() only decrements the reference count of value on success. The calling code must PyDECREF() manually on error. Fixed by attached patch. |
|||
| msg369714 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2020-05-23 11:13 | |
This issue could probably be expanded to the whole Modules directory. A lot of the modules fail to clean up properly on PyModule_AddObject() error. |
|||
| msg369972 - (view) | Author: Dong-hee Na (corona10) *  |
Date: 2020-05-26 12:18 | |
New changeset 5eb45d7d4e812e89d77da84cc619e9db81561a34 by Erlend Egeberg Aasland in branch 'master': bpo-40737: Fix possible reference leak for sqlite3 initialization (GH-20323) https://github.com/python/cpython/commit/5eb45d7d4e812e89d77da84cc619e9db81561a34 |
|||
| msg369975 - (view) | Author: miss-islington (miss-islington) | Date: 2020-05-26 12:38 | |
New changeset 7df9c41c69e2af8d0d36452c09d243b0975495af by Miss Islington (bot) in branch '3.9': bpo-40737: Fix possible reference leak for sqlite3 initialization (GH-20323) https://github.com/python/cpython/commit/7df9c41c69e2af8d0d36452c09d243b0975495af |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:31 | admin | set | github: 84914 |
| 2020-05-26 12:39:23 | corona10 | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-05-26 12:38:54 | miss-islington | set | messages: + msg369975 |
| 2020-05-26 12:18:33 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request19683 |
| 2020-05-26 12:18:22 | corona10 | set | nosy:
+ corona10 messages: + msg369972 |
| 2020-05-25 18:08:13 | erlendaasland | set | title: Handle PyModule_AddObject() error correctly in sqlite3 -> Fix possible reference leak for sqlite3 initialization |
| 2020-05-23 11:13:47 | erlendaasland | set | messages: + msg369714 |
| 2020-05-22 22:18:08 | erlendaasland | set | stage: patch review pull_requests: + pull_request19592 |
| 2020-05-22 22:16:00 | erlendaasland | create | |