➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-05-17 06:46 by hakancelik, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 20147 | closed | hakancelik, 2020-05-17 07:00 | |
| Messages (4) | |||
|---|---|---|---|
| msg369097 - (view) | Author: Hakan Çelik (hakancelik) * | Date: 2020-05-17 06:46 | |
When I use [unimport](https://github.com/hakancelik96/unimport), I saw this problem and I am sending a PR to fix it. |
|||
| msg369099 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2020-05-17 07:03 | |
I do not think there is something wrong with the current code. |
|||
| msg369100 - (view) | Author: Hakan Çelik (hakancelik) * | Date: 2020-05-17 07:08 | |
Are code quality enhancement contributions not accepted? Since the 'from x import * `structure is used in the current code, it is not understood where the objects come from. I thought it would be good to fix this. |
|||
| msg369103 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2020-05-17 08:30 | |
Pure cosmetic changes to satisfy some aesthetic preferences are not accepted. Every changes has its cost (it consumes the time of core developers to review, has maintenance cost, and disturbs the history of the files) and should be made only if it has a clear benefit.
Using star-import is not forbidden, otherwise such syntax would not be supported. ctypes may be one of modules for which using it is well justified: it contains a lot of names, and most of names have unique prefix ("c_") to avoid conflicts with builtins. Especially in tests.
|
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:31 | admin | set | github: 84835 |
| 2020-05-17 08:30:05 | serhiy.storchaka | set | status: open -> closed resolution: rejected messages: + msg369103 stage: patch review -> resolved |
| 2020-05-17 07:08:36 | hakancelik | set | messages: + msg369100 |
| 2020-05-17 07:03:33 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg369099 |
| 2020-05-17 07:00:05 | hakancelik | set | keywords:
+ patch stage: patch review pull_requests: + pull_request19452 |
| 2020-05-17 06:53:57 | hakancelik | set | title: Fix a bad programming practice from 'from x import *', 'Lib / ctypes / test /'. -> Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'. |
| 2020-05-17 06:52:17 | hakancelik | set | title: Fix from a bad programming practice 'from x import *', 'Lib / ctypes / test /'. -> Fix a bad programming practice from 'from x import *', 'Lib / ctypes / test /'. |
| 2020-05-17 06:46:10 | hakancelik | create | |