classification
Title: Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.
Type: Stage: resolved
Components: Tests Versions: Python 3.9, Python 3.8, Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: hakancelik, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2020-05-17 06:46 by hakancelik, last changed 2020-05-17 08:30 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 20147 closed hakancelik, 2020-05-17 07:00
Messages (4)
msg369097 - (view) Author: Hakan Çelik (hakancelik) * Date: 2020-05-17 06:46
When I use [unimport](https://github.com/hakancelik96/unimport), I saw this problem and I am sending a PR to fix it.
msg369099 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-05-17 07:03
I do not think there is something wrong with the current code.
msg369100 - (view) Author: Hakan Çelik (hakancelik) * Date: 2020-05-17 07:08
Are code quality enhancement contributions not accepted?

Since the 'from x import * `structure is used in the current code, it is not understood where the objects come from.

I thought it would be good to fix this.
msg369103 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-05-17 08:30
Pure cosmetic changes to satisfy some aesthetic preferences are not accepted. Every changes has its cost (it consumes the time of core developers to review, has maintenance cost, and disturbs the history of the files) and should be made only if it has a clear benefit.

Using star-import is not forbidden, otherwise such syntax would not be supported. ctypes may be one of modules for which using it is well justified: it contains a lot of names, and most of names have unique prefix ("c_") to avoid conflicts with builtins. Especially in tests.
History
Date User Action Args
2020-05-17 08:30:05serhiy.storchakasetstatus: open -> closed
resolution: rejected
messages: + msg369103

stage: patch review -> resolved
2020-05-17 07:08:36hakanceliksetmessages: + msg369100
2020-05-17 07:03:33serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg369099
2020-05-17 07:00:05hakanceliksetkeywords: + patch
stage: patch review
pull_requests: + pull_request19452
2020-05-17 06:53:57hakanceliksettitle: Fix a bad programming practice from 'from x import *', 'Lib / ctypes / test /'. -> Fix 'from x import *' which is bad programming practice from 'Lib/ctypes/test/'.
2020-05-17 06:52:17hakanceliksettitle: Fix from a bad programming practice 'from x import *', 'Lib / ctypes / test /'. -> Fix a bad programming practice from 'from x import *', 'Lib / ctypes / test /'.
2020-05-17 06:46:10hakancelikcreate