This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Zipapp example has parameters in the wrong order
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Leron Gray, ZackerySpytz, docs@python, miss-islington, xtreak
Priority: normal Keywords: patch

Created on 2020-03-31 23:28 by Leron Gray, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 19290 merged ZackerySpytz, 2020-04-02 00:51
PR 19339 merged miss-islington, 2020-04-03 16:36
PR 19340 merged miss-islington, 2020-04-03 16:36
Messages (5)
msg365436 - (view) Author: Leron Gray (Leron Gray) Date: 2020-03-31 23:28
The second example listed here for zipapp has the parameters in the wrong order. 

https://docs.python.org/3/library/zipapp.html?highlight=zipapp#examples

It should be create_archive("myapp", "myapp.pyz") since the parameters are (source, target). The documentation for the function itself is correct though.
msg365708 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2020-04-03 16:36
New changeset bd6a4c3d72828d3d0e13922e165998539d24f8bc by Zackery Spytz in branch 'master':
bpo-40131: Fix source and target order in zipapp example (GH-19290)
https://github.com/python/cpython/commit/bd6a4c3d72828d3d0e13922e165998539d24f8bc
msg365709 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2020-04-03 17:14
New changeset e6783981df6ae5c63f73be67cc41b1350bc0fcc6 by Miss Islington (bot) in branch '3.8':
bpo-40131: Fix source and target order in zipapp example (GH-19290) (GH-19339)
https://github.com/python/cpython/commit/e6783981df6ae5c63f73be67cc41b1350bc0fcc6
msg365710 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2020-04-03 17:14
New changeset d19162fe5b2aba48a94278baa0f569fc42932072 by Miss Islington (bot) in branch '3.7':
bpo-40131: Fix source and target order in zipapp example (GH-19290) (GH-19340)
https://github.com/python/cpython/commit/d19162fe5b2aba48a94278baa0f569fc42932072
msg365711 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2020-04-03 17:18
Thanks Leron for the report. Thanks Zackery for the patch.
History
Date User Action Args
2022-04-11 14:59:28adminsetgithub: 84312
2020-04-03 17:18:29xtreaksetstatus: open -> closed
versions: - Python 3.5, Python 3.6
messages: + msg365711

resolution: fixed
stage: patch review -> resolved
2020-04-03 17:14:20xtreaksetmessages: + msg365710
2020-04-03 17:14:02xtreaksetmessages: + msg365709
2020-04-03 16:36:52miss-islingtonsetpull_requests: + pull_request18704
2020-04-03 16:36:46miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request18703
2020-04-03 16:36:42xtreaksetnosy: + xtreak
messages: + msg365708
2020-04-02 00:51:39ZackerySpytzsetkeywords: + patch
nosy: + ZackerySpytz

pull_requests: + pull_request18649
stage: patch review
2020-03-31 23:28:17Leron Graycreate