classification
Title: test_importlib.test_zip requires zlib but not marked
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, jaraco, rth, xtreak
Priority: normal Keywords: easy, patch

Created on 2020-03-21 07:27 by xtreak, last changed 2020-03-24 19:08 by jaraco. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 19105 merged rth, 2020-03-21 15:43
Messages (3)
msg364727 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2020-03-21 07:27
I was trying to compile and run tests on a fresh ubuntu 18.03 machine that didn't zlib. test_importlb.test_zip seems to have some tests that depend on zlib but not marked as such causing test errors. Like other tests these could be skipped zlib is not available using test.support.requires_zlib . Tests are as below : 

test_zip_version
test_zip_entry_points
test_case_insensitive
test_files
msg364959 - (view) Author: Jason R. Coombs (jaraco) * (Python committer) Date: 2020-03-24 19:03
New changeset 15e5024d04fc89d948ae761d88048bc58a56b650 by Roman Yurchak in branch 'master':
bpo-40029 mark test_importlib.test_zip as requiring zlib (#19105)
https://github.com/python/cpython/commit/15e5024d04fc89d948ae761d88048bc58a56b650
msg364960 - (view) Author: Jason R. Coombs (jaraco) * (Python committer) Date: 2020-03-24 19:08
Thanks for the report and the fix.
History
Date User Action Args
2020-03-24 19:08:19jaracosetstatus: open -> closed
resolution: fixed
messages: + msg364960

stage: patch review -> resolved
2020-03-24 19:03:00jaracosetnosy: + jaraco
messages: + msg364959
2020-03-21 15:43:23rthsetkeywords: + patch
nosy: + rth

pull_requests: + pull_request18465
stage: needs patch -> patch review
2020-03-21 09:04:26serhiy.storchakasetversions: + Python 3.7, Python 3.8
2020-03-21 09:04:15serhiy.storchakasetkeywords: + easy
stage: needs patch
2020-03-21 07:27:13xtreakcreate