classification
Title: Remove Param expression context from AST
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BTaskaya, pablogsal, vstinner
Priority: normal Keywords: patch

Created on 2020-03-15 14:56 by BTaskaya, last changed 2020-03-19 19:05 by BTaskaya. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 19020 merged BTaskaya, 2020-03-15 14:59
Messages (4)
msg364238 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python triager) Date: 2020-03-15 14:56
Param is an expression context that is no longer in use, we can simply remove it. This node predates the arguments node, and if I am not misguessing used inside of function signatures.
msg364249 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2020-03-15 19:32
New changeset 8689209e0338943dba9b7ff5566b8a420374764c by Batuhan Ta┼čkaya in branch 'master':
bpo-39969: Remove ast.Param node class as is no longer used (GH-19020)
https://github.com/python/cpython/commit/8689209e0338943dba9b7ff5566b8a420374764c
msg364624 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-03-19 18:37
FYI this change broke the chameleon project:
https://github.com/malthe/chameleon/issues/303

Batuhan: You maybe want to propose a fix there. It shouldn't be hard to fix the issue.
msg364632 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python triager) Date: 2020-03-19 19:05
> Batuhan: You maybe want to propose a fix there. It shouldn't be hard to fix the issue.

Serhiy has an open PR about adding some dummy classes that will represent recent deletions like Suite, Param and AugStore/Load. https://github.com/python/cpython/pull/19056
History
Date User Action Args
2020-03-19 19:05:08BTaskayasetmessages: + msg364632
2020-03-19 18:37:38vstinnersetnosy: + vstinner
messages: + msg364624
2020-03-15 19:32:35pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-03-15 19:32:21pablogsalsetnosy: + pablogsal
messages: + msg364249
2020-03-15 14:59:03BTaskayasetkeywords: + patch
stage: patch review
pull_requests: + pull_request18369
2020-03-15 14:56:22BTaskayacreate