This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: The AST is mangled when compiling starred assignments
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: brandtbucher Nosy List: brandtbucher, pablogsal
Priority: normal Keywords: patch

Created on 2020-03-07 20:35 by brandtbucher, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18833 merged brandtbucher, 2020-03-07 20:37
Messages (3)
msg363616 - (view) Author: Brandt Bucher (brandtbucher) * (Python committer) Date: 2020-03-07 20:35
It looks like assignment_helper is the only place where we actually change the semantic meaning of the AST during compilation (a starred name is changed to a regular name as a shortcut).

This probably isn't a great idea, and it would bite us later if we started making multiple passes or reusing the AST or something.
msg363628 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2020-03-08 03:44
New changeset d5aa2e941ccc44412b95d0e3f0a1789fbcccf403 by Brandt Bucher in branch 'master':
bpo-39890: Don't mutate the AST when compiling starred assignments (GH-18833)
https://github.com/python/cpython/commit/d5aa2e941ccc44412b95d0e3f0a1789fbcccf403
msg363630 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2020-03-08 03:44
Thanks for the great catch, Brandt!
History
Date User Action Args
2022-04-11 14:59:27adminsetgithub: 84071
2020-03-08 03:44:53pablogsalsetstatus: open -> closed
resolution: fixed
messages: + msg363630

stage: patch review -> resolved
2020-03-08 03:44:25pablogsalsetnosy: + pablogsal
messages: + msg363628
2020-03-08 00:25:34brandtbuchersettitle: The AST is mangled when compiling starred assignments. -> The AST is mangled when compiling starred assignments
2020-03-07 20:37:31brandtbuchersetkeywords: + patch
stage: patch review
pull_requests: + pull_request18190
2020-03-07 20:35:12brandtbuchercreate