classification
Title: Use the codecov GH Action
Type: Stage:
Components: Versions:
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: ammar2, brett.cannon, steve.dower
Priority: normal Keywords:

Created on 2020-02-27 21:09 by brett.cannon, last changed 2020-02-27 21:26 by ammar2.

Messages (3)
msg362839 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2020-02-27 21:09
Codecov provides a GH Action for uploading coverage reports which we might as well use instead of their bash uploader: https://github.com/marketplace/actions/codecov.
msg362843 - (view) Author: Ammar Askar (ammar2) * (Python triager) Date: 2020-02-27 21:22
This has the disadvantage that it won't work for PRs because Github doesn't make secrets like `${{ secrets.CODECOV_TOKEN }}` available in PRs.

See: https://github.com/codecov/codecov-action/issues/29
msg362845 - (view) Author: Ammar Askar (ammar2) * (Python triager) Date: 2020-02-27 21:26
On a second look, we currently do this anyway: https://github.com/python/cpython/blob/374d998b507d34a6c0a3816a163926a8ba0c483f/.github/workflows/coverage.yml#L66-L70

and don't run coverage for PRs so it shouldn't matter.
History
Date User Action Args
2020-02-27 21:26:43ammar2setmessages: + msg362845
2020-02-27 21:22:40ammar2setnosy: + ammar2
messages: + msg362843
2020-02-27 21:09:04brett.cannoncreate