classification
Title: Remove unnecessary size calculation in array_modexec in Modules/arraymodule.c
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: petdance, vstinner
Priority: normal Keywords: patch

Created on 2020-02-27 05:56 by petdance, last changed 2020-03-04 14:54 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18675 merged petdance, 2020-02-27 06:32
Messages (2)
msg362772 - (view) Author: Andy Lester (petdance) * Date: 2020-02-27 05:56
The array_modexec function in Modules/arraymodule.c has a loop that calculates the number of elements in the descriptors array.  This size was used at one point, but is no longer.  The loop can be removed.
msg363353 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-03-04 14:52
New changeset 702e09fd0ad72b248b5adfa0fcfdb58600be77f6 by Andy Lester in branch 'master':
bpo-39770, array module: Remove unnecessary descriptor counting (GH-18675)
https://github.com/python/cpython/commit/702e09fd0ad72b248b5adfa0fcfdb58600be77f6
History
Date User Action Args
2020-03-04 14:54:29vstinnersetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: + Python 3.9
2020-03-04 14:52:19vstinnersetnosy: + vstinner
messages: + msg363353
2020-02-27 06:38:00petdancesetpull_requests: - pull_request18035
2020-02-27 06:37:48petdancesetpull_requests: - pull_request18034
2020-02-27 06:37:19petdancesetpull_requests: + pull_request18035
2020-02-27 06:37:09petdancesetpull_requests: + pull_request18034
2020-02-27 06:34:05petdancesetpull_requests: - pull_request18031
2020-02-27 06:33:57petdancesetpull_requests: - pull_request18032
2020-02-27 06:32:49petdancesetpull_requests: + pull_request18033
2020-02-27 06:04:16petdancesetpull_requests: + pull_request18032
2020-02-27 05:58:12petdancesetkeywords: + patch
stage: patch review
pull_requests: + pull_request18031
2020-02-27 05:56:10petdancecreate