➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-02-25 20:17 by Marco Sulla, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Messages (2) | |||
|---|---|---|---|
| msg362662 - (view) | Author: Marco Sulla (Marco Sulla) * | Date: 2020-02-25 20:17 | |
I noticed that `__contains__()` and `__getitem__()` of subclasses of `dict` are much slower. I asked why on StackOverflow, and an user seemed to find the reason. The problem for him/her is that `dict` implements directly `__contains__()` and `__getitem__()`. Usually, `sq_contains` and `mp_subscript` are wrapped to implement `__contains__()` and `__getitem__()`, but this way `dict` is a little faster, I suppose. The problem is that `update_one_slot()` searches for the wrappers. If it does not find them, it does not inherit the `__contains__()` and `__getitem__()` of the class, but create a `__contains__()` and `__getitem__()` functions that do an MRO search and call the superclass method. This is why `__contains__()` and `__getitem__()` of `dict` subclasses are slower. Is it possible to modify `update_one_slot()` so that, if no wrapper is found, the explicit implementation is inherited? SO answer: https://stackoverflow.com/a/59914459/1763602 |
|||
| msg362677 - (view) | Author: Benjamin Peterson (benjamin.peterson) *  |
Date: 2020-02-26 02:17 | |
See also #34396. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:27 | admin | set | github: 83935 |
| 2020-02-26 19:09:15 | Marco Sulla | set | status: open -> closed resolution: duplicate stage: resolved |
| 2020-02-26 02:17:47 | benjamin.peterson | set | nosy:
+ benjamin.peterson messages: + msg362677 |
| 2020-02-25 20:17:09 | Marco Sulla | create | |