This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: 2to3 fix_exitfunc suggests duplicated import of atexit module
Type: behavior Stage: resolved
Components: 2to3 (2.x to 3.x conversion tool) Versions:
process
Status: closed Resolution: wont fix
Dependencies: Superseder: Close 2to3 issues and list them here
View: 45544
Assigned To: Nosy List: ilya, phsilva
Priority: normal Keywords: patch

Created on 2020-02-19 02:18 by ilya, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18654 closed phsilva, 2020-02-25 08:10
Messages (1)
msg362245 - (view) Author: (ilya) Date: 2020-02-19 02:18
Consider the following code:

import sys

def foo():
    print(1)

def bar():
    print(2)

if input("case: ") == 1:
    sys.exitfunc = foo
else:
    sys.exitfunc = bar

2to3 -f exitfunc suggests to fix it as follows:

--- a.py	(original)
+++ a.py	(refactored)
@@ -1,4 +1,6 @@
 import sys
+import atexit
+import atexit
 
 def foo():
     print(1)
@@ -7,6 +9,6 @@
     print(2)
 
 if input("case: ") == 1:
-    sys.exitfunc = foo
+    atexit.register(foo)
 else:
-    sys.exitfunc = bar
+    atexit.register(bar)

So it seems that it produces one import of atexit module per each use of sys.exitfunc.
History
Date User Action Args
2022-04-11 14:59:26adminsetgithub: 83864
2021-10-20 22:55:43iritkatrielsetstatus: open -> closed
resolution: wont fix
superseder: Close 2to3 issues and list them here
stage: patch review -> resolved
2020-02-25 08:10:07phsilvasetkeywords: + patch
nosy: + phsilva

pull_requests: + pull_request18015
stage: patch review
2020-02-19 02:18:46ilyacreate