classification
Title: 3.6+ documentation for MAKE_FUNCTION
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, miss-islington, serhiy.storchaka, thautwarm
Priority: normal Keywords: easy, patch

Created on 2020-02-18 13:20 by thautwarm, last changed 2020-03-14 14:55 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18549 closed thautwarm, 2020-02-18 14:06
PR 18550 merged thautwarm, 2020-02-18 14:22
PR 18993 merged miss-islington, 2020-03-14 14:24
PR 18994 merged miss-islington, 2020-03-14 14:24
Messages (7)
msg362208 - (view) Author: thautwarm (thautwarm) * Date: 2020-02-18 13:20
LINK: https://docs.python.org/3.6/library/dis.html?highlight=bytecode#opcode-MAKE_FUNCTION

To avoid being confusing, MAKE_FUNCTION(argc) shall be MAKE_FUNCTION(flag), since 3.6 the operand of MAKE_FUNCTION never means `argcount`.
msg362209 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-02-18 13:31
Agree. Do you want to provide a PR?

Although it may be too later for 3.6 which only takes security fixes.
msg362211 - (view) Author: thautwarm (thautwarm) * Date: 2020-02-18 13:47
Okay, I'll make a PR. It's okay because users will always check docs of version 3 instead of a specific version like 3.6.
msg364169 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-03-14 14:24
New changeset 6672c16b1d7f83789bf3a2016bd19edfd3568e71 by Taine Zhao in branch 'master':
bpo-39677: dis: rename the operand of MAKE_FUNCTION from `argc` to `flags` for 3.6+ (GC-18550)
https://github.com/python/cpython/commit/6672c16b1d7f83789bf3a2016bd19edfd3568e71
msg364173 - (view) Author: miss-islington (miss-islington) Date: 2020-03-14 14:45
New changeset 725cbce25084a67ad7ff48b75cca3e240ef57606 by Miss Islington (bot) in branch '3.7':
bpo-39677: dis: rename the operand of MAKE_FUNCTION from `argc` to `flags` for 3.6+ (GC-18550)
https://github.com/python/cpython/commit/725cbce25084a67ad7ff48b75cca3e240ef57606
msg364175 - (view) Author: miss-islington (miss-islington) Date: 2020-03-14 14:45
New changeset a927e91186727b5184d774d1d99c70b9ff5497f5 by Miss Islington (bot) in branch '3.8':
bpo-39677: dis: rename the operand of MAKE_FUNCTION from `argc` to `flags` for 3.6+ (GC-18550)
https://github.com/python/cpython/commit/a927e91186727b5184d774d1d99c70b9ff5497f5
msg364176 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-03-14 14:55
Sorry for the delay with review and thank you for your contribution.
History
Date User Action Args
2020-03-14 14:55:45serhiy.storchakasetstatus: open -> closed
versions: - Python 3.6
messages: + msg364176

resolution: fixed
stage: patch review -> resolved
2020-03-14 14:45:27miss-islingtonsetmessages: + msg364175
2020-03-14 14:45:14miss-islingtonsetmessages: + msg364173
2020-03-14 14:24:24miss-islingtonsetpull_requests: + pull_request18341
2020-03-14 14:24:18miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request18340
2020-03-14 14:24:10serhiy.storchakasetmessages: + msg364169
2020-02-18 14:22:36thautwarmsetpull_requests: + pull_request17930
2020-02-18 14:06:07thautwarmsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request17929
2020-02-18 13:47:54thautwarmsetmessages: + msg362211
2020-02-18 13:31:56serhiy.storchakasetversions: + Python 3.7, Python 3.8, Python 3.9
nosy: + serhiy.storchaka

messages: + msg362209

keywords: + easy
stage: needs patch
2020-02-18 13:20:52thautwarmcreate