classification
Title: md5_compress() in Modules/md5module.c can take a const buf
Type: enhancement Stage: resolved
Components: Extension Modules Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, miss-islington, petdance
Priority: normal Keywords: patch

Created on 2020-02-13 04:05 by petdance, last changed 2020-02-13 05:12 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18497 merged petdance, 2020-02-13 04:08
PR 18498 merged miss-islington, 2020-02-13 04:53
Messages (3)
msg361932 - (view) Author: Andy Lester (petdance) * Date: 2020-02-13 04:05
The function md5_compress does not modify its buffer argument.

static void md5_compress(struct md5_state *md5, unsigned char *buf)

buf should be const.
msg361934 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2020-02-13 04:53
New changeset 597ebed748d0b0c061f8c108bd98270d103286c1 by Andy Lester in branch 'master':
closes bpo-39621: Make buf arg to md5_compress be const. (GH-18497)
https://github.com/python/cpython/commit/597ebed748d0b0c061f8c108bd98270d103286c1
msg361935 - (view) Author: miss-islington (miss-islington) Date: 2020-02-13 05:12
New changeset 669981b3b14dd16dec42089d6ac8d6449fde8abd by Miss Islington (bot) in branch '3.8':
closes bpo-39621: Make buf arg to md5_compress be const. (GH-18497)
https://github.com/python/cpython/commit/669981b3b14dd16dec42089d6ac8d6449fde8abd
History
Date User Action Args
2020-02-13 05:12:56miss-islingtonsetnosy: + miss-islington
messages: + msg361935
2020-02-13 04:53:20miss-islingtonsetpull_requests: + pull_request17872
2020-02-13 04:53:08benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg361934

resolution: fixed
stage: patch review -> resolved
2020-02-13 04:08:54petdancesetkeywords: + patch
stage: patch review
pull_requests: + pull_request17871
2020-02-13 04:05:21petdancecreate