classification
Title: test_largefile: TestSocketSendfile.test_it() uses too much disk space
Type: Stage: resolved
Components: Tests Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: giampaolo.rodola, vstinner
Priority: normal Keywords: buildbot, patch

Created on 2020-01-29 17:14 by vstinner, last changed 2020-02-05 17:23 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18261 merged giampaolo.rodola, 2020-01-29 23:15
Messages (3)
msg360976 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-01-29 17:14
TestSocketSendfile.test_it() failed with "OSError: [Errno 28] No space left on device" on PPC64LE Fedora 3.x buildbot.

It also caused troubles on "AMD64 Fedora Rawhide Clang 3.x" worker.

If I recall correctly, it writes like 8 GB of real data, not just empty files made of holes.

I suggest to either remove the test or to use way less disk space.

https://buildbot.python.org/all/#builders/11/builds/259

Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_largefile.py", line 161, in test_it
    shutil.copyfile(TESTFN, TESTFN2)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 270, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 163, in _fastcopy_sendfile
    raise err from None
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 149, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
OSError: [Errno 28] No space left on device: '@test_38097_tmp' -> '@test_38097_tmp2'
msg361440 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-02-05 17:21
New changeset b39fb8e847ac59b539ad7e93df91c1709815180e by Giampaolo Rodola in branch 'master':
bpo-39488: Skip test_largefile tests if not enough disk space (GH-18261)
https://github.com/python/cpython/commit/b39fb8e847ac59b539ad7e93df91c1709815180e
msg361441 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-02-05 17:23
Giampaolo Rodola modified the tests to skip them if there is not enough disk space. Let's see if it's enough to fix these buildbots. Since the issue was random, I close the issue and just hope that it's now fixed :-)
History
Date User Action Args
2020-02-05 17:23:24vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg361441

stage: patch review -> resolved
2020-02-05 17:21:00vstinnersetmessages: + msg361440
2020-01-29 23:15:06giampaolo.rodolasetkeywords: + patch
stage: patch review
pull_requests: + pull_request17637
2020-01-29 17:14:09vstinnercreate