classification
Title: Allow to deprecate CLI arguments in argparse
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: 4383, djarb, paul.j3, rhettinger, serhiy.storchaka, shihai1991
Priority: normal Keywords: patch

Created on 2020-01-27 18:14 by 4383, last changed 2020-03-03 12:57 by 4383.

Pull Requests
URL Status Linked Edit
PR 18208 open 4383, 2020-01-27 18:17
Messages (6)
msg360786 - (view) Author: hervé (4383) * Date: 2020-01-27 18:14
Today it's not possible to deprecate CLI arguments designed with argparse, it could be useful to introduce deprecation feature in argparse to allow developers to inform their apps's users when an argument is planed to be removed in the future.
msg360827 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2020-01-27 23:55
Will leave this open for a while so that many people can comment on the proposal before we act on it.

My initial take is:

* Having a way to deprecate seems useful.

* In practice, I haven't seen this done very much (in big tooling such as GCC perhaps, but everyday command-line tools don't seem to do this AFAICT).

* The warnings module is likely not the right implementation tool.  The warnings module doesn't make as much sense for CLIs as it does for libraries.  In particular, the warnings module is all about the ability of consumer code to filter, ignore, or escalate warnings.  Also, we've so far been good about minimizing inter-module dependencies so that start-up time remains fast.

* The PR is aggressive in providing *deprecated*, *deprecated_reason*, and *deprecated_pending*.  Perhaps a simpler hook or flag would suffice.  The overall module API is already large enough to be a barrier to learning all the features.

* There is some question as to whether this belongs in argparse at all or whether it should be in downstream, post-parsing logic.  For example:

    parser.add_argument('--throw', action='store_true',
             help = '(deprecated use "toss" instead) causes ball to move')
    ...
    args = parser.parse_args()
    if args.throw:
         print('"throw" has been deprecated, use "toss" instead',
               file=sys.stderr)
msg360861 - (view) Author: hervé (4383) * Date: 2020-01-28 10:31
First, thanks Raymond for your worth useful comment.

* Concerning the usage of the warning module what do you suggest to use then?  To use "print"? 

* Concerning "hook or flag" and the 3 new params in my PR, I think developers would appreciate to give a customized message to their users to inform that something will be removed for X reasons in the X release. The "pending" notion could be removed to keep the API lightweight, but with a well documented feature I don't seen terrible thing to understand here, maybe we need to put more effort on documentation and example (related to my changes).

* Concerning the fact to move deprecation management outside the declaration of the argument, I think it could be misleading to deprecate something in another place in the code, in other words it could introduce some more difficulties to understand the code. If the deprecation is declared in the argument declaration then all the info are centralized in one place and the parser know what to do in this situation.

Thoughts?
msg361155 - (view) Author: Hai Shi (shihai1991) * (Python triager) Date: 2020-02-01 08:10
IMHO, cli should only support atomic function.What is atomic functin? (if downstream software's feature can not keep alive without upstream fucntion, it must be an atomic function).
msg361158 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-02-01 08:50
In general I agree with Raymond, although I am warmer to this feature. And I think we should have a mechanism to deprecate not only options, but subcommands.

* The warnings module is used for warning about the use of API. It outputs the file and the line number of the caller to help the developer to fix his code. It allows to hide warnings from non-developers.

But warnings about deprecated CLI options and commands are purposed to be shown to the user of the CLI. They should not contain references to source code, because it is not the cause of the warning. The argparse module should use the same mechanism for warnings and errors: output to stderr.

* I do not understand the purpose of deprecated_pending. The feature is either deprecated or not. If it is deprecated, using it will produce a warning. If it is not deprecated -- no warning. In case of silent deprecation you can manually add a note in the help.

* I am not sure about deprecated_reason. We do not have a way to specify error message for standard errors (such like about missed required argument). If you need a custom warning, do not use the standard deprecation mechanism and emits a warning manually.

* As for moving the output of a warning to post-parsing logic, this is not always convenient and possible.

Let you have options "--verbose" which increments the verbosity level and "--verbosity-level" which sets it directly. One of them is deprecated. We can't easily use a post-parsing logic because they set the same destination. In this case we can workaround this by rewriting the logic to use different destinations, but there this is not always possible. Imagine you have options --add and --append which append the argument to the list and want to deprecate one of them. You can't use different lists and merge them in post-parsing, because the relative order matters.
msg363256 - (view) Author: hervé (4383) * Date: 2020-03-03 12:57
hello,

First thanks everyone to took time to discute about this proposal.

This topic is now opened since ~1 months so I don't think we will more feedback about this, then I will address all your comments in my changes soon to match an implementation more consensually based.
History
Date User Action Args
2020-03-03 12:57:114383setnosy: + 4383
messages: + msg363256
2020-02-01 08:50:55serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg361158
2020-02-01 08:10:48shihai1991setnosy: + shihai1991, - 4383
messages: + msg361155
2020-01-28 10:31:534383setnosy: + 4383
messages: + msg360861
2020-01-27 23:55:21rhettingersetmessages: - msg360813
2020-01-27 23:55:07rhettingersetmessages: + msg360827
2020-01-27 22:25:10rhettingersetmessages: + msg360813
2020-01-27 18:24:35xtreaksetnosy: + rhettinger, djarb, paul.j3, - 4383
2020-01-27 18:17:344383setkeywords: + patch
stage: patch review
pull_requests: + pull_request17585
2020-01-27 18:14:114383create