classification
Title: turtle.py - minor bugfixes
Type: behavior Stage:
Components: Library (Lib) Versions: Python 2.6
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: gregorlingl, loewis
Priority: normal Keywords: patch

Created on 2008-09-23 00:16 by gregorlingl, last changed 2008-09-23 05:21 by loewis. This issue is now closed.

Files
File name Uploaded Description Edit
turtle.py.diff gregorlingl, 2008-09-23 00:16 Bugfixes for bugs described in this issue
turtleDemo.diff gregorlingl, 2008-09-23 00:20 Diff for bugfix to make turtleDemo work correctly with fixed turtle.py
Messages (3)
msg73607 - (view) Author: Gregor Lingl (gregorlingl) Date: 2008-09-23 00:16
Thorough testing revealesd the following bugs in turtle.py (Python 2.6):

1) Around lines 359 and 379: There's a name conflict with a methodname
of the parentclass Frame: _root. The bugfix consists in renaming this
attribute, which occurs only twice

2) Around line 732: Turtles with image-shapes do not recognize user
coordinates. This is fixed in  TurtleScreenBase method _drawimage by
introducing the corresponding scaling factors

3) Around line 3570: Calling the __init__ - Method of the Screen-class
(which uses the Borg idiom) destroys graphics and Turtles on the Screen.
This is an undesired behaviour. The fix brings the behaviour of Screen
in accordance with the Python 3.0 version.

4) Around line 3612: Screen.setup() needs a final update() call in order
to ensure, that immediately following calls of window_width() or
window_height() return correct values.

Moreover there is a correction of the version number and date

Bugfixes are attached in turtle.py.diff

Regards,
Gregor
msg73608 - (view) Author: Gregor Lingl (gregorlingl) Date: 2008-09-23 00:20
The bugfix for bug 3) described above makes necessary the insertion of a
line in turtleDemo.py (around line 96)

Again I've attached the corresponding diff file
msg73615 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-09-23 05:21
Please submit separate patches for unrelated issues. As a whole, the
patch is unacceptable because of that.

Please don't add comments to the code that describe what has changed, or
what was before. Only describe what is. Specifically, don't say
"renamed:...".

Also, for each issue, it would be good if you could provide a short test
case that demonstrates the bug that gets fixed with the patch.
History
Date User Action Args
2008-09-23 05:21:32loewissetstatus: open -> closed
resolution: rejected
messages: + msg73615
nosy: + loewis
2008-09-23 00:20:43gregorlinglsetfiles: + turtleDemo.diff
messages: + msg73608
2008-09-23 00:16:15gregorlinglcreate