classification
Title: wrong rst syntax in socket.rst
Type: Stage: resolved
Components: Documentation Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Mariatta, Oz.Tiram, docs@python, miss-islington
Priority: normal Keywords: patch

Created on 2020-01-15 23:41 by Oz.Tiram, last changed 2020-01-16 00:01 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18018 merged Oz.Tiram, 2020-01-15 23:43
PR 18019 merged miss-islington, 2020-01-15 23:55
PR 18020 merged miss-islington, 2020-01-15 23:55
Messages (5)
msg360086 - (view) Author: Oz Tiram (Oz.Tiram) * Date: 2020-01-15 23:41
The code block for the isn't hightlighted:



Changed in version 3.7: When SOCK_NONBLOCK or SOCK_CLOEXEC bit flags are applied to type they are cleared, and socket.type will not reflect them. They are still passed to the underlying system socket() call. Therefore::

    sock = socket.socket(

...

This is because the double colon is directly after the word Therefore.


This fix is very simple:

       :attr:`socket.type` will not reflect them.  They are still passed
-      to the underlying system `socket()` call.  Therefore::
+      to the underlying system `socket()` call.  Therefore,
+
+      ::
 
           sock = socket.socket(
               socket.AF_INET,
       ...


I have prepared a PR for this.
msg360087 - (view) Author: miss-islington (miss-islington) Date: 2020-01-15 23:55
New changeset fad8b5674c66d9e00bb788e30adddb0c256c787b by Miss Islington (bot) (Oz N Tiram) in branch 'master':
bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018)
https://github.com/python/cpython/commit/fad8b5674c66d9e00bb788e30adddb0c256c787b
msg360088 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2020-01-15 23:57
Thanks!
msg360089 - (view) Author: miss-islington (miss-islington) Date: 2020-01-16 00:00
New changeset 970188c2d792133e2273924a987e0542659a676f by Miss Islington (bot) in branch '3.7':
bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018)
https://github.com/python/cpython/commit/970188c2d792133e2273924a987e0542659a676f
msg360090 - (view) Author: miss-islington (miss-islington) Date: 2020-01-16 00:01
New changeset 19bd3a18626b504dc92abb44019cad600c7ef221 by Miss Islington (bot) in branch '3.8':
bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018)
https://github.com/python/cpython/commit/19bd3a18626b504dc92abb44019cad600c7ef221
History
Date User Action Args
2020-01-16 00:01:28miss-islingtonsetmessages: + msg360090
2020-01-16 00:00:39miss-islingtonsetmessages: + msg360089
2020-01-15 23:57:06Mariattasetnosy: + Mariatta
messages: + msg360088
2020-01-15 23:56:55Mariattasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-01-15 23:55:34miss-islingtonsetpull_requests: + pull_request17415
2020-01-15 23:55:26miss-islingtonsetpull_requests: + pull_request17414
2020-01-15 23:55:18miss-islingtonsetnosy: + miss-islington
messages: + msg360087
2020-01-15 23:43:22Oz.Tiramsetkeywords: + patch
stage: patch review
pull_requests: + pull_request17413
2020-01-15 23:41:24Oz.Tiramcreate