This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Unused error message in _sharedexception_bind
Type: behavior Stage: resolved
Components: Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: alex.henrie, benjamin.peterson, miss-islington
Priority: normal Keywords: patch

Created on 2020-01-08 18:22 by alex.henrie, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 17908 merged alex.henrie, 2020-01-08 18:24
PR 17913 merged miss-islington, 2020-01-09 02:49
Messages (3)
msg359620 - (view) Author: Alex Henrie (alex.henrie) * Date: 2020-01-08 18:22
The function _sharedexception_bind currently has the following bit of code in two places:

    if (PyErr_ExceptionMatches(PyExc_MemoryError)) {
        failure = "out of memory copying exception type name";
    }
    failure = "unable to encode and copy exception type name";

The "out of memory" message will never appear because it is immediately overwritten with a more generic message.
msg359649 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2020-01-09 02:48
New changeset 5cae042f686cc174e00093944dc118914c874b7c by Benjamin Peterson (Alex Henrie) in branch 'master':
closes bpo-39262: Use specific out-of-memory message in _sharedexception_bind. (GH-17908)
https://github.com/python/cpython/commit/5cae042f686cc174e00093944dc118914c874b7c
msg359651 - (view) Author: miss-islington (miss-islington) Date: 2020-01-09 03:07
New changeset 45e5750a013291c5729e0ebad2b9e340fdffbd36 by Miss Islington (bot) in branch '3.8':
closes bpo-39262: Use specific out-of-memory message in _sharedexception_bind. (GH-17908)
https://github.com/python/cpython/commit/45e5750a013291c5729e0ebad2b9e340fdffbd36
History
Date User Action Args
2022-04-11 14:59:25adminsetgithub: 83443
2020-01-09 03:07:44miss-islingtonsetnosy: + miss-islington
messages: + msg359651
2020-01-09 02:49:13miss-islingtonsetpull_requests: + pull_request17325
2020-01-09 02:48:56benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg359649

resolution: fixed
stage: patch review -> resolved
2020-01-08 18:24:50alex.henriesetkeywords: + patch
stage: patch review
pull_requests: + pull_request17319
2020-01-08 18:22:29alex.henriecreate