➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-12-15 19:45 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 17619 | merged | serhiy.storchaka, 2019-12-15 19:49 | |
| PR 17829 | merged | miss-islington, 2020-01-05 12:14 | |
| PR 17830 | merged | miss-islington, 2020-01-05 12:14 | |
| Messages (4) | |||
|---|---|---|---|
| msg358444 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2019-12-15 19:45 | |
There are several issues with urllib.request.proxy_bypass_environment: 1. Leading dots are ignored in the proxy list, but not in the checked hostname. So ".localhost" does not matches ".localhost" in the proxy list. 2. A single trailing \n in the checked hostname is ignored, so "localhost\n" passes the check if the proxy list contains "localhost". But "localhost\n\n" and "localhost " do not pass. This is an artifact of using $ in the regular expression. |
|||
| msg359332 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2020-01-05 12:14 | |
New changeset 6a265f0d0c0a4b3b8fecf4275d49187a384167f4 by Serhiy Storchaka in branch 'master': bpo-39057: Fix urllib.request.proxy_bypass_environment(). (GH-17619) https://github.com/python/cpython/commit/6a265f0d0c0a4b3b8fecf4275d49187a384167f4 |
|||
| msg359335 - (view) | Author: miss-islington (miss-islington) | Date: 2020-01-05 12:31 | |
New changeset 880a17af7d063fcef225a46b7f4ae35d792b2f11 by Miss Islington (bot) in branch '3.7': bpo-39057: Fix urllib.request.proxy_bypass_environment(). (GH-17619) https://github.com/python/cpython/commit/880a17af7d063fcef225a46b7f4ae35d792b2f11 |
|||
| msg359336 - (view) | Author: miss-islington (miss-islington) | Date: 2020-01-05 12:32 | |
New changeset fc84d501b9d77701cbdd485de45e200bf027c0e9 by Miss Islington (bot) in branch '3.8': bpo-39057: Fix urllib.request.proxy_bypass_environment(). (GH-17619) https://github.com/python/cpython/commit/fc84d501b9d77701cbdd485de45e200bf027c0e9 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:24 | admin | set | github: 83238 |
| 2020-01-05 13:33:12 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-01-05 12:32:04 | miss-islington | set | messages: + msg359336 |
| 2020-01-05 12:31:47 | miss-islington | set | nosy:
+ miss-islington messages: + msg359335 |
| 2020-01-05 12:14:55 | miss-islington | set | pull_requests: + pull_request17257 |
| 2020-01-05 12:14:48 | miss-islington | set | pull_requests: + pull_request17256 |
| 2020-01-05 12:14:38 | serhiy.storchaka | set | messages: + msg359332 |
| 2019-12-15 19:49:37 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17089 |
| 2019-12-15 19:45:57 | serhiy.storchaka | create | |