This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_largefile: TestSocketSendfile.test_it() failed on AMD64 Fedora Stable Refleaks 3.x
Type: Stage: resolved
Components: Tests Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: giampaolo.rodola, pablogsal, vstinner
Priority: normal Keywords: patch

Created on 2019-12-09 13:24 by vstinner, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 17552 merged giampaolo.rodola, 2019-12-10 08:27
Messages (5)
msg358075 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-12-09 13:24
0:22:15 load avg: 15.82 [288/420/3] test_largefile failed (11 min 19 sec) -- running: test_capi (2 min 40 sec), test_compileall (3 min 42 sec), test_shelve (14 min 46 sec), test_sax (10 min 4 sec), test_dbm (3 min 36 sec), test_multiprocessing_spawn (13 min 21 sec), test_posix (3 min 39 sec), test_mailbox (12 min 46 sec), test_asyncio (9 min 23 sec)
beginning 6 repetitions
123456
.Warning -- threading._dangling was modified by test_largefile
  Before: {<weakref at 0x7f1cf0e08fb0; to '_MainThread' at 0x7f1cf19395a0>}
  After:  {<weakref at 0x7f1cf0526470; to '_MainThread' at 0x7f1cf19395a0>, <weakref at 0x7f1cf0526170; to 'Thread' at 0x7f1cf057a3c0>} 
test test_largefile failed -- Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_largefile.py", line 211, in test_it
    self.assertEqual(os.path.getsize(TESTFN2), size)
AssertionError: 2496925696 != 2500000001
msg358076 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-12-09 13:25
AMD64 Fedora Stable Refleaks 3.x:
https://buildbot.python.org/all/#/builders/126/builds/14
msg358172 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2019-12-10 08:29
I suspect it's a timing problem (client disconnects, threaded server fails to detect that in time). Let's see what happens by incrementing the timeout when waiting for the thread to be join()ed (PR-17552).
msg358174 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2019-12-10 09:31
New changeset 82374979ec7e01e23385dca1d02b2aa3de16fea5 by Giampaolo Rodola in branch 'master':
bpo-39004: increment large sendfile() test timeout (GH-17552)
https://github.com/python/cpython/commit/82374979ec7e01e23385dca1d02b2aa3de16fea5
msg358184 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-12-10 12:29
Let's say that it's enough to hide the race condition :-) I close the issue.
History
Date User Action Args
2022-04-11 14:59:24adminsetgithub: 83185
2019-12-10 12:29:56vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg358184

stage: patch review -> resolved
2019-12-10 09:31:23giampaolo.rodolasetmessages: + msg358174
2019-12-10 08:29:47giampaolo.rodolasetmessages: + msg358172
2019-12-10 08:27:48giampaolo.rodolasetkeywords: + patch
stage: patch review
pull_requests: + pull_request17026
2019-12-09 13:25:53vstinnersettitle: test_largefile: test_it() failed on -> test_largefile: TestSocketSendfile.test_it() failed on AMD64 Fedora Stable Refleaks 3.x
nosy: + giampaolo.rodola, pablogsal

messages: + msg358076

versions: + Python 3.9
components: + Tests
2019-12-09 13:24:37vstinnercreate