classification
Title: code.replace() does not raise audit event
Type: Stage: resolved
Components: Versions: Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: miss-islington, steve.dower
Priority: normal Keywords: patch

Created on 2019-11-26 20:13 by steve.dower, last changed 2019-11-27 00:46 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 17394 merged steve.dower, 2019-11-26 20:22
PR 17396 merged miss-islington, 2019-11-27 00:28
Messages (3)
msg357529 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-11-26 20:13
Because code.replace() manually creates a new code object (that is, with arbitrary co_code rather than via the compiler), it should raise code.__new__ with its arguments.
msg357542 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-11-27 00:27
New changeset c7c01ab1e5415b772c68e15f1aba51e520010830 by Steve Dower in branch 'master':
bpo-38922: Raise code.__new__ audit event when code object replace() is called (GH-17394)
https://github.com/python/cpython/commit/c7c01ab1e5415b772c68e15f1aba51e520010830
msg357543 - (view) Author: miss-islington (miss-islington) Date: 2019-11-27 00:46
New changeset 191f94cca6f8cf59535e7459c1113e4a1cdfe201 by Miss Islington (bot) in branch '3.8':
bpo-38922: Raise code.__new__ audit event when code object replace() is called (GH-17394)
https://github.com/python/cpython/commit/191f94cca6f8cf59535e7459c1113e4a1cdfe201
History
Date User Action Args
2019-11-27 00:46:36miss-islingtonsetnosy: + miss-islington
messages: + msg357543
2019-11-27 00:28:36steve.dowersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-11-27 00:28:04miss-islingtonsetpull_requests: + pull_request16877
2019-11-27 00:27:54steve.dowersetmessages: + msg357542
2019-11-26 20:22:01steve.dowersetkeywords: + patch
stage: patch review
pull_requests: + pull_request16876
2019-11-26 20:13:46steve.dowercreate