classification
Title: configure: on macOS (darwin) add CoreFoundation to flags before checking for gettext
Type: compile error Stage: patch review
Components: Build, macOS Versions: Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Jakub Piotr Cłapa, barry, ned.deily, ronaldoussoren
Priority: normal Keywords: patch

Created on 2019-11-08 11:34 by Jakub Piotr Cłapa, last changed 2019-11-08 17:13 by barry.

Pull Requests
URL Status Linked Edit
PR 17090 open Jakub Piotr Cłapa, 2019-11-08 11:36
Messages (1)
msg356237 - (view) Author: Jakub Piotr Cłapa (Jakub Piotr Cłapa) * Date: 2019-11-08 11:34
macOS needs to link to CoreFoundation for gettext to work. We reorder the autoconf tests so CoreFoundation is added to LIBS earlier and the -lintl test does not fail (which would exclude it from the final set of flags).

Btw. the whole test seems fishy: if compilation fails it does not mean -lintl is not needed, for this we would need to test a gettext function without -lintl. Basically two tests (with and without -lintl) are needed to properly diagnose the situation. The test in question had been written in 2009 as a fix for the https://bugs.python.org/issue6154 bug report.

This may be an issue only with non-Framework builds (since Homebrew manages to build a framework-based Python on macOS without any special shenigans) but I had not tested it.
History
Date User Action Args
2019-11-08 17:13:39barrysetnosy: + barry
2019-11-08 16:35:50ned.deilysetnosy: + ronaldoussoren, ned.deily
components: + macOS
2019-11-08 11:36:53Jakub Piotr Cłapasetkeywords: + patch
stage: patch review
pull_requests: + pull_request16599
2019-11-08 11:34:01Jakub Piotr Cłapacreate