➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-11-07 19:42 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 17083 | merged | serhiy.storchaka, 2019-11-07 19:43 | |
| PR 17125 | merged | serhiy.storchaka, 2019-11-12 15:08 | |
| PR 17128 | merged | serhiy.storchaka, 2019-11-12 17:00 | |
| PR 31678 | merged | maggyero, 2022-03-04 20:11 | |
| PR 31690 | merged | miss-islington, 2022-03-04 20:13 | |
| Messages (9) | |||
|---|---|---|---|
| msg356210 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2019-11-07 19:42 | |
The proposed PR fixes some issues with True and False in the documentation: * "Return true/false" is replaced with "Return ``True``/``False``" if the function actually returns a bool. * Fixed formatting of some True and False literals (now in monospace). * Replaced "True/False" with "true/false" if it can be not only bool. * Replaced some 1/0 with True/False if it corresponds the code. |
|||
| msg356254 - (view) | Author: Vedran Čačić (veky) * | Date: 2019-11-08 18:55 | |
Very nice. I aplaud your return to the original Python terminology, of true and false as adjectives, and True and False as names for specific objects. Perlisms such as `truthy` or `that evaluates as True` simply make my head spin. I wrote one comment, regarding the case where you have the default value mentioned. Otherwise, I think it is a very nice change. |
|||
| msg356466 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-11-12 14:57 | |
New changeset 138ccbb02216ca086047c3139857fb44f3dab1f9 by Serhiy Storchaka in branch 'master': bpo-38738: Fix formatting of True and False. (GH-17083) https://github.com/python/cpython/commit/138ccbb02216ca086047c3139857fb44f3dab1f9 |
|||
| msg356473 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-11-12 16:54 | |
New changeset d360346640e19231032b072216195484fa2450b4 by Serhiy Storchaka in branch '3.8': [3.8] bpo-38738: Fix formatting of True and False. (GH-17083) (GH-17125) https://github.com/python/cpython/commit/d360346640e19231032b072216195484fa2450b4 |
|||
| msg356477 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-11-12 18:07 | |
New changeset 42b619ac9aa7f889dcd8eeb14d813f17468454d9 by Serhiy Storchaka in branch '3.7': [3.7] bpo-38738: Fix formatting of True and False. (GH-17083) (GH-17128) https://github.com/python/cpython/commit/42b619ac9aa7f889dcd8eeb14d813f17468454d9 |
|||
| msg356507 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2019-11-12 23:43 | |
Serhiy, thank you for carrying this through, including the backports. Ready to close? |
|||
| msg356535 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-11-13 15:26 | |
Thanks Vinay, Kyle and Terry for your review! |
|||
| msg414549 - (view) | Author: Gregory P. Smith (gregory.p.smith) * |
Date: 2022-03-04 20:13 | |
New changeset 46a116c1c9f6b60a3d35ab9a419f8eee5de2542e by Géry Ogam in branch 'main': bpo-38738: Fix formatting of True and False in the threading documentation (GH-31678) https://github.com/python/cpython/commit/46a116c1c9f6b60a3d35ab9a419f8eee5de2542e |
|||
| msg414550 - (view) | Author: miss-islington (miss-islington) | Date: 2022-03-04 20:38 | |
New changeset fa69ec89393549a18944b3b92943709dac56a36a by Miss Islington (bot) in branch '3.10': bpo-38738: Fix formatting of True and False in the threading documentation (GH-31678) https://github.com/python/cpython/commit/fa69ec89393549a18944b3b92943709dac56a36a |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:22 | admin | set | github: 82919 |
| 2022-03-04 20:38:07 | miss-islington | set | messages: + msg414550 |
| 2022-03-04 20:13:24 | gregory.p.smith | set | nosy:
+ gregory.p.smith messages: + msg414549 |
| 2022-03-04 20:13:21 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request29810 |
| 2022-03-04 20:11:49 | maggyero | set | nosy:
+ maggyero pull_requests: + pull_request29809 |
| 2019-11-13 15:26:19 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg356535 stage: patch review -> resolved |
| 2019-11-12 23:43:40 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg356507 |
| 2019-11-12 18:07:30 | serhiy.storchaka | set | messages: + msg356477 |
| 2019-11-12 17:00:15 | serhiy.storchaka | set | pull_requests: + pull_request16637 |
| 2019-11-12 16:54:30 | serhiy.storchaka | set | messages: + msg356473 |
| 2019-11-12 15:08:00 | serhiy.storchaka | set | pull_requests: + pull_request16633 |
| 2019-11-12 14:57:10 | serhiy.storchaka | set | messages: + msg356466 |
| 2019-11-08 18:55:19 | veky | set | nosy:
+ veky messages: + msg356254 |
| 2019-11-07 19:43:03 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request16593 |
| 2019-11-07 19:42:20 | serhiy.storchaka | create | |