➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-10-28 14:56 by shihai1991, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 16963 | closed | shihai1991, 2019-10-28 14:59 | |
| Messages (3) | |||
|---|---|---|---|
| msg355547 - (view) | Author: Hai Shi (shihai1991) *  |
Date: 2019-10-28 14:56 | |
1) param is unpredictable; 2) the compiler_free() use Py_XDECREF(c->c_filename) in PyAST_CompileObject(); |
|||
| msg355552 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2019-10-28 15:46 | |
The filename argument must be non-NULL. The code that uses c_filename requires this. Py_XDECREF in compiler_free() could be replaced with Py_DECREF. But this is too tiny change which does not have significant effect. Actually both Py_INCREF and Py_XDECREF could be removed. |
|||
| msg355563 - (view) | Author: Hai Shi (shihai1991) * |
Date: 2019-10-28 16:42 | |
Got it, thanks, Serhiy. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:22 | admin | set | github: 82798 |
| 2019-10-28 16:42:22 | shihai1991 | set | messages: + msg355563 |
| 2019-10-28 15:59:23 | serhiy.storchaka | set | status: open -> closed resolution: not a bug stage: patch review -> resolved |
| 2019-10-28 15:46:29 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg355552 |
| 2019-10-28 14:59:12 | shihai1991 | set | keywords:
+ patch stage: patch review pull_requests: + pull_request16491 |
| 2019-10-28 14:56:23 | shihai1991 | create | |