➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Using Py_XDECREF to replace Py_DECREF in PyAST_FromNodeObject()
Type: enhancement Stage: resolved
Components: Interpreter Core Versions: Python 3.9
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: serhiy.storchaka, shihai1991
Priority: normal Keywords: patch

Created on 2019-10-28 14:41 by shihai1991, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 16962 closed shihai1991, 2019-10-28 14:43
Messages (2)
msg355545 - (view) Author: Hai Shi (shihai1991) * (Python triager) Date: 2019-10-28 14:41 
`if (c.c_normalize) {
     Py_DECREF(c.c_normalize);
}` 
--> 
`Py_XDECREF(c.c_normalize);`
msg355554 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-10-28 15:53 
Both code are equivalent. There is reason to rewrite this. It would just increase code churn.
History
Date User Action Args
2022-04-11 14:59:22adminsetgithub: 82797
2019-11-17 08:45:49corona10setpull_requests: - pull_request16708
2019-11-17 08:44:03corona10setpull_requests: + pull_request16708
2019-11-17 08:43:35corona10setpull_requests: - pull_request16706
2019-11-17 08:43:06corona10setpull_requests: + pull_request16706
2019-10-28 15:53:30serhiy.storchakasetstatus: open -> closed

nosy: + serhiy.storchaka
messages: + msg355554

resolution: rejected
stage: patch review -> resolved
2019-10-28 14:43:22shihai1991setkeywords: + patch
stage: patch review
pull_requests: + pull_request16490
2019-10-28 14:41:07shihai1991create