classification
Title: Implement unix read_pipe.is_reading() method
Type: enhancement Stage: patch review
Components: asyncio Versions: Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: asvetlov, benedwards14, callumquick, shubh07, yselivanov
Priority: normal Keywords: newcomer friendly, patch

Created on 2019-09-29 11:22 by asvetlov, last changed 2019-12-30 13:53 by callumquick.

Pull Requests
URL Status Linked Edit
PR 17042 closed callumquick, 2019-11-04 12:24
PR 17755 open callumquick, 2019-12-30 13:53
Messages (7)
msg353494 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-09-29 11:22
Sockets support it, there is no reason for missing the method in unix pipe.
msg353495 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-09-29 11:23
The issue is easy, basically we need the following code plus a test

    def is_reading(self):
        return not self._paused and not self._closing
msg353499 - (view) Author: Shubham Upreti (shubh07) * Date: 2019-09-29 12:59
I would like to take this up. I am a beginner and any more instructions you want to give me.
msg353500 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-09-29 13:19
Nothing special.
There is UnixReadPipeTransportTests test cases inside Lib/test/test_asyncio/test_unix_events.py

This class has a bunch of tests for pause_reading() / resume_reading().

Test(s) for is_reading() can be built in the same way.
msg355465 - (view) Author: Benjamin Edwards (benedwards14) * Date: 2019-10-27 13:23
Shubham are you still interested in this, or are you ok with me taking it on?
msg355484 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-10-27 17:24
Please do.
msg355939 - (view) Author: Callum Ward (callumquick) * Date: 2019-11-04 11:17
I've agreed with Ben that I'll look at making the necessary changes today.
History
Date User Action Args
2019-12-30 13:53:39callumquicksetpull_requests: + pull_request17192
2019-11-04 12:24:52callumquicksetkeywords: + patch
stage: patch review
pull_requests: + pull_request16555
2019-11-04 11:17:29callumquicksetnosy: + callumquick
messages: + msg355939
2019-10-27 17:24:29asvetlovsetmessages: + msg355484
2019-10-27 13:23:22benedwards14setnosy: + benedwards14
messages: + msg355465
2019-09-29 13:19:14asvetlovsetmessages: + msg353500
2019-09-29 12:59:50shubh07setnosy: + shubh07
messages: + msg353499
2019-09-29 11:23:16asvetlovsetkeywords: + newcomer friendly
type: enhancement
messages: + msg353495
2019-09-29 11:22:13asvetlovcreate