➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: shutil.make_archive() should allow setting zipfile.ZipFile() 'strict_timestamps'
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: serhiy.storchaka, ta1hia, valorien
Priority: normal Keywords: patch

Created on 2019-09-26 16:43 by valorien, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL Status Linked Edit
PR 16797 open ta1hia, 2019-10-14 22:32
Messages (4)
msg353329 - (view) Author: Alori (valorien) Date: 2019-09-26 16:43 
https://bugs.python.org/issue34097 addressed a zipfile.ZipFile() issue where zip files with timestamps prior to the year 1980 could not be created. The fix adds the strict_timestamps=True|False keyword argument to the ZipFile class.

shutil.make_archive() is a high-level utility that uses ZipFile() to simplify zip file creation. Unfortunately, it doesn't support the new 'strict_timestamps' keyword which means users encountering the 'ValueError: ZIP does not support timestamps before 1980' exception must revert to using zipfile.ZipFile() instead.

I believe adding the 'strict_timestamps' keyword to shutil.make_archive() and propagating it to zipfileZipFile()
msg353330 - (view) Author: Alori (valorien) Date: 2019-09-26 16:51 
...would solve the issue (cut off from previous post)
msg353331 - (view) Author: Tahia K (ta1hia) * Date: 2019-09-26 17:23 
Hello,

I'm interested in picking this task up. Would it be alright for me to grab it?
msg354673 - (view) Author: Tahia K (ta1hia) * Date: 2019-10-14 22:34 
I went ahead and picked this one up :) PR is posted to github.
History
Date User Action Args
2022-04-11 14:59:20adminsetgithub: 82469
2019-10-15 04:29:02xtreaksetnosy: + serhiy.storchaka
2019-10-14 22:34:20ta1hiasetmessages: + msg354673
2019-10-14 22:32:37ta1hiasetkeywords: + patch
stage: patch review
pull_requests: + pull_request16353
2019-09-26 17:23:45ta1hiasetnosy: + ta1hia
messages: + msg353331
2019-09-26 16:51:00valoriensetmessages: + msg353330
2019-09-26 16:43:50valoriencreate