➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-09-19 09:37 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 16281 | merged | serhiy.storchaka, 2019-09-19 09:40 | |
| Messages (2) | |||
|---|---|---|---|
| msg352777 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2019-09-19 09:37 | |
Currently most shutil tests are in a single class. Tests for the same function are partially grouped together and partially intermixed with other tests. This makes hard to find an appropriate place for adding new tests and increase risk of hiding test by other test with the same name. The proposed PR reorganized shutil tests. Added separate classes for particular functions and groups of related functions. It also cleans up some code: creating temporary dirs and monkey-patching shutil.open. test.support.rmtree() is used instead of shutil.rmtree() for cleaning up temporary dirs (it is more reliable for testing purposes). I am going to add new tests, so I need to clean up the existing code first. |
|||
| msg353289 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-09-26 10:15 | |
New changeset 4f2eac04e4fee4d7d188ad2eeb0e610e3d7254bb by Serhiy Storchaka in branch 'master': bpo-38223: Reorganize test_shutil. (GH-16281) https://github.com/python/cpython/commit/4f2eac04e4fee4d7d188ad2eeb0e610e3d7254bb |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:20 | admin | set | github: 82404 |
| 2019-09-26 10:17:00 | serhiy.storchaka | set | status: open -> closed stage: patch review -> resolved resolution: fixed versions: - Python 2.7, Python 3.7, Python 3.8 |
| 2019-09-26 10:15:12 | serhiy.storchaka | set | messages: + msg353289 |
| 2019-09-19 09:40:28 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request15866 |
| 2019-09-19 09:37:09 | serhiy.storchaka | create | |