This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: [EASY] tkinter.filedialog.askopenfilenames should follow PEP8
Type: Stage: resolved
Components: Tkinter Versions: Python 3.9
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: corona10, serhiy.storchaka, taleinat
Priority: low Keywords: newcomer friendly

Created on 2019-09-14 15:34 by corona10, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Messages (2)
msg352438 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2019-09-14 15:34
https://github.com/python/cpython/blob/39d87b54715197ca9dcb6902bb43461c0ed701a2/Lib/tkinter/filedialog.py#L397

This should be
options["multiple"]=1 -> options["multiple"] = 1
msg352440 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-09-14 16:02
We usually do not accept pure cosmetic changes.

From PEP 8:

Some other good reasons to ignore a particular guideline:

3. Because the code in question predates the introduction of the guideline and there is no other reason to be modifying that code.
History
Date User Action Args
2022-04-11 14:59:20adminsetgithub: 82354
2019-09-14 16:02:06serhiy.storchakasetstatus: open -> closed

nosy: + serhiy.storchaka
messages: + msg352440

resolution: rejected
stage: resolved
2019-09-14 15:35:15corona10setkeywords: + newcomer friendly
2019-09-14 15:34:56corona10create