➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-09-09 11:38 by asvetlov, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 15762 | closed | asvetlov, 2019-09-09 11:41 | |
| PR 15847 | merged | miss-islington, 2019-09-10 12:56 | |
| Messages (6) | |||
|---|---|---|---|
| msg351433 - (view) | Author: Andrew Svetlov (asvetlov) *  |
Date: 2019-09-09 11:38 | |
As discussed in discussion https://github.com/python/cpython/pull/14488#discussion_r322176319 Hide feed_eof(), feed_data(), set_exception() and set_transport() methods. |
|||
| msg351439 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2019-09-09 12:24 | |
BTW, if we are doing this -- maybe not expose the underlying transport at all? I don't like that we do that currently, and there multiple ways for the user to screw up the Stream object (and potentially break start_tls()/sendfile() etc) |
|||
| msg351549 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2019-09-09 20:16 | |
Done. The only API from transport that users really need is get_extra_info() which is exposed as a stream method already. |
|||
| msg351634 - (view) | Author: miss-islington (miss-islington) | Date: 2019-09-10 12:56 | |
New changeset 12c122ae958a55c9874ed4c7d7805ceb084411d7 by Miss Islington (bot) (Andrew Svetlov) in branch 'master': bpo-38066: Hide internal Stream methods (GH-15762) https://github.com/python/cpython/commit/12c122ae958a55c9874ed4c7d7805ceb084411d7 |
|||
| msg351659 - (view) | Author: miss-islington (miss-islington) | Date: 2019-09-10 13:44 | |
New changeset f12ff05bc07ac087743a4615c4af5f66b73f8d2c by Miss Islington (bot) in branch '3.8': bpo-38066: Hide internal Stream methods (GH-15762) https://github.com/python/cpython/commit/f12ff05bc07ac087743a4615c4af5f66b73f8d2c |
|||
| msg362736 - (view) | Author: (tzickel) * | Date: 2020-02-26 20:56 | |
The documentation needs to scrub this methods as well, for example: https://docs.python.org/3/library/asyncio-stream.html#asyncio.StreamReader.at_eof still mentions them. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:20 | admin | set | github: 82247 |
| 2020-02-26 20:56:24 | tzickel | set | nosy:
+ tzickel messages: + msg362736 |
| 2019-09-10 14:04:17 | asvetlov | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-09-10 13:44:38 | miss-islington | set | messages: + msg351659 |
| 2019-09-10 12:56:25 | miss-islington | set | pull_requests: + pull_request15493 |
| 2019-09-10 12:56:17 | miss-islington | set | nosy:
+ miss-islington messages: + msg351634 |
| 2019-09-09 20:16:41 | asvetlov | set | messages: + msg351549 |
| 2019-09-09 12:24:09 | yselivanov | set | messages: + msg351439 |
| 2019-09-09 11:41:37 | asvetlov | set | keywords:
+ patch stage: patch review pull_requests: + pull_request15415 |
| 2019-09-09 11:38:35 | asvetlov | create | |