classification
Title: Hide internal asyncio.Stream methods
Type: Stage: resolved
Components: asyncio Versions: Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: asvetlov, miss-islington, yselivanov
Priority: normal Keywords: patch

Created on 2019-09-09 11:38 by asvetlov, last changed 2019-09-10 14:04 by asvetlov. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 15762 closed asvetlov, 2019-09-09 11:41
PR 15847 merged miss-islington, 2019-09-10 12:56
Messages (5)
msg351433 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-09-09 11:38
As discussed in discussion https://github.com/python/cpython/pull/14488#discussion_r322176319

Hide feed_eof(), feed_data(), set_exception() and set_transport() methods.
msg351439 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2019-09-09 12:24
BTW, if we are doing this -- maybe not expose the underlying transport at all?  I don't like that we do that currently, and there multiple ways for the user to screw up the Stream object (and potentially break start_tls()/sendfile() etc)
msg351549 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-09-09 20:16
Done.
The only API from transport that users really need is get_extra_info() which is exposed as a stream method already.
msg351634 - (view) Author: miss-islington (miss-islington) Date: 2019-09-10 12:56
New changeset 12c122ae958a55c9874ed4c7d7805ceb084411d7 by Miss Islington (bot) (Andrew Svetlov) in branch 'master':
bpo-38066: Hide internal Stream methods (GH-15762)
https://github.com/python/cpython/commit/12c122ae958a55c9874ed4c7d7805ceb084411d7
msg351659 - (view) Author: miss-islington (miss-islington) Date: 2019-09-10 13:44
New changeset f12ff05bc07ac087743a4615c4af5f66b73f8d2c by Miss Islington (bot) in branch '3.8':
bpo-38066: Hide internal Stream methods (GH-15762)
https://github.com/python/cpython/commit/f12ff05bc07ac087743a4615c4af5f66b73f8d2c
History
Date User Action Args
2019-09-10 14:04:17asvetlovsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-09-10 13:44:38miss-islingtonsetmessages: + msg351659
2019-09-10 12:56:25miss-islingtonsetpull_requests: + pull_request15493
2019-09-10 12:56:17miss-islingtonsetnosy: + miss-islington
messages: + msg351634
2019-09-09 20:16:41asvetlovsetmessages: + msg351549
2019-09-09 12:24:09yselivanovsetmessages: + msg351439
2019-09-09 11:41:37asvetlovsetkeywords: + patch
stage: patch review
pull_requests: + pull_request15415
2019-09-09 11:38:35asvetlovcreate