classification
Title: Skip individual unit tests that are expensive for the PGO task
Type: enhancement Stage: resolved
Components: Build Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: nascheme
Priority: normal Keywords: patch

Created on 2019-07-29 18:34 by nascheme, last changed 2019-07-30 18:34 by nascheme. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 15009 merged nascheme, 2019-07-29 18:40
PR 15024 merged miss-islington, 2019-07-30 18:08
Messages (3)
msg348677 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2019-07-29 18:34
Add a new support decorator, @skip_if_pgo_task and then use it to mark test cases.  I suspect the PGO task works well if it can exercise common code paths.  Running long tests likely have rapidly diminishing benefits.  The instrumented PGO executable runs quite a bit slower than a normal build and so it is useful to spend a bit of time to exclude expensive tests.
msg348763 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2019-07-30 18:08
New changeset 52a48e62c6a94577152f9301bbe5f3bc806cfcf1 by Neil Schemenauer in branch 'master':
bpo-37707: Exclude expensive unit tests from PGO task (GH-15009)
https://github.com/python/cpython/commit/52a48e62c6a94577152f9301bbe5f3bc806cfcf1
msg348767 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2019-07-30 18:34
New changeset 382cb85401bb010ead411c0532499ffe16c3cf27 by Neil Schemenauer (Miss Islington (bot)) in branch '3.8':
bpo-37707: Exclude expensive unit tests from PGO task (GH-15009) (#15024)
https://github.com/python/cpython/commit/382cb85401bb010ead411c0532499ffe16c3cf27
History
Date User Action Args
2019-07-30 18:34:48naschemesetmessages: + msg348767
2019-07-30 18:12:56naschemesetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-07-30 18:08:37miss-islingtonsetpull_requests: + pull_request14786
2019-07-30 18:08:26naschemesetmessages: + msg348763
2019-07-29 18:40:55naschemesetkeywords: + patch
pull_requests: + pull_request14772
2019-07-29 18:34:07naschemecreate